greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

feat: Defining a custom default presentation on BBB server

Open jgribonvald opened this issue 4 years ago • 14 comments

Setting from a site configuration the default presentation URL

Description

This permit to define at the site configuration a default presentation page when launching a new room on the bbb server. It permits to override the default presentation of BBB server. This default presentation won't override the user pre-loaded presentation.

Testing Steps

Screenshots (if appropriate):

screenshot

jgribonvald avatar Mar 24 '21 14:03 jgribonvald

Mhh I think that the test are not passing as the @Settings isn't init in test mode, How can I do that ? Or do you see an other way ? Thansk for your help.

Else I remove the tests as I'm sure this is working

jgribonvald avatar Mar 25 '21 16:03 jgribonvald

Test are passing now !

jgribonvald avatar Mar 27 '21 12:03 jgribonvald

Hi,

To help us better test and review community PRs, we have now implemented a mandatory PR template. We would really appreciate it if you were to update the description of this PR to match the template below.

For more information, please see: https://github.com/bigbluebutton/greenlight#source-code--contributing

The template must be in the following format (it is automatically applied to all new PRs):

<!--- 
IMPORTANT
This template is mandatory for all Pull Requests.
Please follow the template to ensure your Pull Request is reviewed.
-->

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Testing Steps
<!--- Please describe in detail how to test your changes. -->

## Screenshots (if appropriate):
<!--- Please include screenshots of ALL visual changes. -->

farhatahmad avatar Apr 06 '21 22:04 farhatahmad

Thank you for applying the changes to the description. If I'm understanding the code correctly, it only allows you to specify a presentation URL but does not allow you to upload a file? If so, I don't believe this method will work. Admins should be able to upload a file to use as the default presentation to keep the actions consistent

farhatahmad avatar Apr 18 '21 17:04 farhatahmad

@farhatahmad Ok I see, in my case (several greenlight in LB) it's better to have a presentation available from an url. Else as the feature use the pre-upload feature, it won't be too much difficult to use both. I will update the PR for that. Just let me some time we are deploying 200 BBB.

jgribonvald avatar Apr 19 '21 10:04 jgribonvald

@farhatahmad I'm not really familiar to RoR and have problems to find a good way to upload files. On an other part, admins have to set an URL on previous options, so if they can provide a custom term or policy URL, they can provide a default file URL... I will try to continue but how do you see that ? should also must provide a different option on settings.rb ? After I'm trying to upload and use the generated url to save it in the same input.

jgribonvald avatar Jun 09 '21 13:06 jgribonvald

Hmm on second thought, I don't think its possible to make this an actual file upload - atleast not with the way the settings currently work. Let me spend some time thinking about this and I'll make a decision

farhatahmad avatar Jun 18 '21 18:06 farhatahmad

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

sonarqubecloud[bot] avatar Oct 02 '21 20:10 sonarqubecloud[bot]

@farhatahmad any news ?

Thanks

jgribonvald avatar Jan 14 '22 08:01 jgribonvald

Can you do a rebase on this please?

farhatahmad avatar Jan 16 '22 22:01 farhatahmad

@farhatahmad rebase done !

jgribonvald avatar Jan 17 '22 08:01 jgribonvald

Needs another rebase :( Or set the Allow maintainers to edit setting so that I can

farhatahmad avatar Jan 20 '22 02:01 farhatahmad

@farhatahmad rebase done again !

The Allow maintainers to edit doesn't appear on PR already done (before the option activated ?), else I need to recreate it, but we will loose all the talk...

jgribonvald avatar Jan 20 '22 07:01 jgribonvald

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

sonarqubecloud[bot] avatar Jan 20 '22 07:01 sonarqubecloud[bot]