neeto-ui icon indicating copy to clipboard operation
neeto-ui copied to clipboard

Updated Storybook to version 8

Open yashjais opened this issue 1 year ago • 1 comments

  • Fixes #2333

This PR updates the Storybook to version 8.

Checklist

  • [ ] ~I have made corresponding changes to the documentation.~
  • [ ] ~I have updated the types definition of modified exports.~
  • [ ] ~I have verified the functionality in some of the neeto web-apps.~
  • [ ] ~I have added tests that prove my fix is effective or that my feature works.~
  • [ ] ~I have added proper data-cy and data-testid attributes.~
  • [x] I have added the necessary label (patch/minor/major - If package publish is required).

Reviewers

yashjais avatar Nov 05 '24 06:11 yashjais

Context:- Storybook isn't picking up the props from React Component and couldn't populate it in args table. The same worked when we upgraded the storybook in neeto-molecules out of the box. The core of this issue could be the warning we are getting in the console when we run yarn storybook locally. This could also be the issue behind the subcomponent props not working.

Screenshot 2024-11-05 at 12 18 33 PM

Screenshot 2024-11-05 at 12 20 29 PM

@AbhayVAshokan _a

You could checkout to this branch(test-2333-show-the-props-of-subcomponents-in-storybook) to check the react-docgen issue. In this branch I've extra commit to match the version of packages with neeto-molecules. Also copied the main file in storybook from neeto-molecules to remove any config issue.

Here's the diff between dependencies for neeto-ui and neeto-molecules.

Few of the approaches I've tried to get this working.

  • Matched the packages and config of neeto-ui and neeto-molecules to get this working in neeto-ui.
  • Tried to update the configs in main.js file of storybook.

Here are few links related to this issue. https://storybook.js.org/docs/api/main-config/main-config-typescript#reactdocgen https://github.com/reactjs/react-docgen/issues https://github.com/storybookjs/storybook/issues/29378

yashjais avatar Nov 05 '24 06:11 yashjais

Closing the PR to clean up the board.

AbhayVAshokan avatar Apr 11 '25 05:04 AbhayVAshokan

@AbhayVAshokan _a I have pushed all the changes. As discussed in the call only the subcomponents part is not working. You can take a look on this.

SumitPanda0 avatar Sep 03 '25 10:09 SumitPanda0