neeto-ui icon indicating copy to clipboard operation
neeto-ui copied to clipboard

Allows user to freeze and unfreeze a column for horizontal scroll.

Open deepakjosp opened this issue 1 year ago • 1 comments

Fixes #2294

Description

  • Implements freeze/unfreeze column feature in the Table.

Checklist

  • [x] I have made corresponding changes to the documentation.
  • [x] I have updated the types definition of modified exports.
  • [x] I have verified the functionality in some of the neeto web-apps.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [ ] ~I have added proper data-cy and data-testid attributes.~
  • [x] I have added the necessary label (patch/minor/major - If package publish is required).

Reviewers

deepakjosp avatar Sep 13 '24 10:09 deepakjosp

@josephmathew900 _a please review. There's a know bug within NeetoForm responses table. I've created an issue for that.

deepakjosp avatar Sep 13 '24 11:09 deepakjosp

@deepakjosp Code changes LGTM. I have tested the issue with viewport resize and it is working fine now. The only issue remaining is with column jumping when freezing and unfreezing a column.

josephmathew900 avatar Sep 19 '24 03:09 josephmathew900

@josephmathew900 the UI glitch is because of the inline style set to the CellContent component. I've created an issue to debug and fix the issue in NeetoUI. Let's merge this PR.

deepakjosp avatar Sep 19 '24 06:09 deepakjosp