neeto-ui icon indicating copy to clipboard operation
neeto-ui copied to clipboard
verified publisher icon bigbinary

Fix time picking logic in DateTimePicker and also add a prop to remove time picker

Open lakshyakanungo opened this issue 1 year ago • 9 comments

https://lakshya.neetorecord.com/watch/64daaa69-9941-42ce-919c-db651ede9c2f cc: @yedhink

lakshyakanungo avatar Feb 14 '24 08:02 lakshyakanungo

@farhanlatheef _a Please take a look into this with some priority. Some of the PRs in planner are dependent on this issue.

cc: @josephmathew900

yedhink avatar Feb 14 '24 11:02 yedhink

@yedhink, I discussed the issue with @lakshyakanungo . I informed him that if the requirement only involves a date, he can simply use the DatePicker from neetoui, which is the same component used in the DateTimePicker for picking dates.

farhanlatheef avatar Feb 14 '24 12:02 farhanlatheef

@farhanlatheef I understand your point. But I was a bit confused on why we are maintaining a DatePicker and a DateTimePicker in neetoUI. Aren't both these is similar with just a addition of Time field? Like do we need to maintain two versions of it?

cc: @praveen-murali-ind

yedhink avatar Feb 14 '24 12:02 yedhink

@yedhink There is no bug with DateTimePicker component. Please check this video https://philson.neetorecord.com/watch/57e62fc2-ce9c-4a74-9a01-d09f53fd6833 cc: @lakshyakanungo

philson-philip avatar Feb 14 '24 21:02 philson-philip

@praveen-murali-ind @philson-philip @farhanlatheef @yedhink https://joseph-mathew.neetorecord.com/watch/41dbe1ee-ee93-418d-a9b5-95dc80597c6e LMK your thoughts.

josephmathew900 avatar Feb 15 '24 11:02 josephmathew900

@josephmathew900 https://farhan-ck.neetorecord.com/watch/fe368116-0ae1-43ea-be0f-f5afd79e1451.

farhanlatheef avatar Feb 16 '24 04:02 farhanlatheef

@josephmathew900 https://philson.neetorecord.com/watch/6692e085-5484-4845-ab8b-774f4dfeb342

philson-philip avatar Feb 16 '24 05:02 philson-philip

@farhanlatheef @philson-philip Agreed.

Action Items:

  • [ ] Remove showTime prop from DatePicker component.
  • [ ] Remove TimePicker component.
  • [ ] Rename TimePickerInput to TimePicker.

Migration is handled in this issue - https://github.com/bigbinary/neeto-engineering-web/issues/630. Once this issue is closed, we can proceed with this.

josephmathew900 avatar Feb 16 '24 06:02 josephmathew900

This issue will be picked up once the rollout is complete. https://github.com/bigbinary/neeto-engineering-web/issues/630.

farhanlatheef avatar Feb 16 '24 06:02 farhanlatheef

This will be addressed in https://github.com/bigbinary/neeto-ui/issues/2234.

josephmathew900 avatar Jun 27 '24 05:06 josephmathew900