decoding-carelink icon indicating copy to clipboard operation
decoding-carelink copied to clipboard

Error checking that SERIAL is defined

Open scottleibrand opened this issue 11 years ago • 3 comments

Since --serial is not a required argument, but must be defined as an environment variable if it's not provided, scripts that require it should error out immediately if SERIAL is undefined.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

scottleibrand avatar Nov 23 '14 02:11 scottleibrand

Hmm, still feel strongly about this? Closing for now; re-open if needed. Also, try to find a user who agrees that if serial is nonsensical to bail. I'm at half a vote, and may be lobbied.

bewest avatar Dec 22 '14 08:12 bewest

This is pretty simple error checking IMO. If we know what causes a common error, we should give a useful error message, and fail early, rather than trying something we know will fail, and returning a cryptic error when it does. On Mon, Dec 22, 2014 at 12:05 AM Ben West [email protected] wrote:

Closed #50 https://github.com/bewest/decoding-carelink/issues/50.

— Reply to this email directly or view it on GitHub https://github.com/bewest/decoding-carelink/issues/50#event-210782866.

scottleibrand avatar Dec 22 '14 18:12 scottleibrand

Re-opening then.

bewest avatar Dec 26 '14 16:12 bewest