bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Allow SPIR-V shaders to process when shader defs are present

Open ProfLander opened this issue 2 years ago • 2 comments

Objective

  • Prevent SPIR-V shaders from being rejected when shader defines are present.

Solution

  • Have ShaderProcessor behave as a passthrough with respect to SPIR-V shaders.

Fixes #7771

ProfLander avatar Feb 21 '23 05:02 ProfLander

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

github-actions[bot] avatar Feb 21 '23 05:02 github-actions[bot]

Any chance of that review, @superdump?

If this relatively small change ends up merged, Bevy Rust-GPU will be a step closer to providing a WGSL-comparable workflow for rust-gpu shader crates in mainline bevy.

ProfLander avatar Mar 04 '23 04:03 ProfLander

This is super important for a (edit: Spirv utilizing) subset of bevy users and we need a solution.

brynnbrancamp avatar Mar 19 '23 00:03 brynnbrancamp