bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Hot reloading is broken in the post_processing example

Open rparrett opened this issue 3 years ago • 1 comments

Bevy version

main

What you did

  • cargo run --example post_processing
  • Update custom_material_chromatic_aberration.wgsl

What went wrong

Shader did not reload

Additional information

Shader examples should use the AssetServerSettings resource to ensure that hot reloading is setup in time for it to actually work.

These other examples are not broken, but we should probably also switch to using AssetServerSettings there to avoid leading people astray when they try to do this with a material shader.

./shader/shader_instancing.rs
./scene/scene.rs

rparrett avatar Sep 12 '22 16:09 rparrett

In my opinion we should remove the watch for changes method. It’s racey and so unpredictable. Better to use the resource from the beginning, in my opinion.

superdump avatar Sep 12 '22 19:09 superdump