bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Sysinfo plugin compilation has been fixed for disabled multi_threaded feature

Open bugsweeper opened this issue 1 year ago • 5 comments

Objective

Solution

  • For non wasm builds FakeTask contains result, which is used by Sysinfo.

Testing

  • Built project with and without feature multi_threaded

bugsweeper avatar Jun 21 '24 13:06 bugsweeper

Worth thinking about how this interacts with #13889

janhohenheim avatar Jun 23 '24 09:06 janhohenheim

Worth thinking about how this interacts with #13889

PR you metioned also tries solve throwing away result, but has amount of work for wasm32 target, that is why that solution should be better. This PR conflicts with that PR, that is why we should wait some time for that PR.

bugsweeper avatar Jun 24 '24 08:06 bugsweeper

Looks like #13889, which I mentioned as better solution is not moving forward anymore

bugsweeper avatar Jul 08 '24 09:07 bugsweeper

Ping @JoJoJet, do you think we should wait for your PR?

janhohenheim avatar Jul 08 '24 09:07 janhohenheim

I can take some time this week to finish up that PR. I don't think it's very far from a mergeable state

joseph-gio avatar Jul 08 '24 14:07 joseph-gio

No longer blocked :)

alice-i-cecile avatar Jul 16 '24 01:07 alice-i-cecile

No longer blocked :)

@alice-i-cecile we can close this PR, and mark #13957 as resolved by #13889

bugsweeper avatar Jul 16 '24 07:07 bugsweeper

@bugsweeper have you verified that the compilation works with the given setup on main? If so, I can file the PR / issue accordingly later.

janhohenheim avatar Jul 16 '24 11:07 janhohenheim

@bugsweeper have you verified that the compilation works with the given setup on main? If so, I can file the PR / issue accordingly later.

Yes, I did ensured successfull compilation before asking for closing this PR

bugsweeper avatar Jul 16 '24 12:07 bugsweeper