bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Fix global wireframe behavior not being applied on new meshes

Open Kanabenki opened this issue 2 years ago • 1 comments

Objective

  • Fixes #11782.

Solution

  • Remove the run condition for apply_global_wireframe_material, since it prevent detecting when meshes are added or the NoWireframe marker component is removed from an entity. Alternatively this could be done by using a run condition like "added Handle<Mesh> or removed NoWireframe or WireframeConfig changed" but this seems less clear to me than directly letting the queries on apply_global_wireframe_material do the filtering.

Kanabenki avatar Feb 09 '24 11:02 Kanabenki

Putting in draft since there is some potential edge cases with NoWireframe I'd like to fix.

Edit: should now properly handle NoWireframe removal.

Kanabenki avatar Feb 09 '24 11:02 Kanabenki

@alice-i-cecile may I suggest this PR for your merge train?

Shatur avatar Feb 12 '24 08:02 Shatur