Explain Camera2dBundle.projection needs to be set carefully

Open stepancheg opened this issue 2 years ago • 3 comments

Encountered it while implementing https://github.com/bevyengine/bevy/pull/11109.

Dec 28 '23 03:12 stepancheg

@matiqo15 I added comment in OrthographicProjection initially, but then decided it is more appropriate on Camera2dBundle, because OrthographicProjection can be used not only with 2D camera.

Dec 28 '23 16:12 stepancheg

Makes sense, but I still think we should at least mention it in OrthographicProjection so that we can point users in the right direction. Would like to get someone else's opinion on this.

Dec 28 '23 18:12 matiqo15

@rodolphito I suspect that might be

fragile to minor changes the project
may result in visual artefacts due to float rounding

But I don't really know.

Jan 15 '24 07:01 stepancheg

I believe this needs to have main merged in; it's try to run CI checks that aren't available it seems.

Mar 12 '24 02:03 TrialDragon