github_pr_tree icon indicating copy to clipboard operation
github_pr_tree copied to clipboard
verified publisher icon berzniz

File missing from individual commit view

Open msorens opened this issue 5 years ago • 5 comments

Summary When I open an individual commit, at least one file is missing from the file tree. I do not know how prevalent this is, I just happened to be able to easily identify one occurrence, so I am passing that on for your consideration. image

My repo is public so I can show you a good example. That screen shot is from this commit: bf2c603 (#4226)

I know that at least one more file is in this commit, components/automate-ui/src/app/pages/create-notification-modal/create-notification-modal.component.ts, because VSCode shows the changes from that specific commit: image

One possible factor that may or may not be relevant: the file in question was added earlier in the commit history of this PR; that is, the PR was not just updating an existing file.

msorens avatar Sep 18 '20 01:09 msorens

I can confirm the bug (2 items in the tree, vs. 6 on the right): Screen Shot 2020-09-18 at 12 51 30

Seems this is due to loading the files in batches by GitHub (see state with only 2 files): Screen Shot 2020-09-18 at 12 52 41

If anyone want to have a go at it, please write here and send a PR.

berzniz avatar Sep 18 '20 09:09 berzniz

Just ran into this, it's also an issue if you select a range of commits

YayC avatar Sep 09 '21 01:09 YayC

@YayC can you verify if the new "Refresh" button in the extension solves that (as a workaround)?

berzniz avatar Sep 09 '21 18:09 berzniz

the refresh button works! thank you!

YayC avatar Sep 09 '21 19:09 YayC

Same problem here. The "Refresh" button works. Are you planning to add auto-refresh of the files list in reaction to some DOM event?

krzysztof-lopacki-gft avatar Dec 13 '21 11:12 krzysztof-lopacki-gft