berty icon indicating copy to clipboard operation
berty copied to clipboard

Account storage key is not removed during delete

Open n0izn0iz opened this issue 4 years ago • 5 comments

n0izn0iz avatar Feb 06 '22 08:02 n0izn0iz

Need to find the key store on iOS. (Maybe look at js/ios/Berty/Sources/Bridge/KeystoreDriver.swift ?) Should also try to find the keystore on Android. (Maybe look at js/android/app/src/main/java/tech/berty/gobridge/KeystoreDriver.java ?)

jefft0 avatar Oct 06 '23 14:10 jefft0

On iOS, handleAppUninstallation calls clearSecureKeyStore(). How to check if this is used when the account is deleted? https://github.com/berty/berty/blob/b323168b99005c759f5db1231830ac827396578a/js/ios/Berty/Sources/Bridge/KeystoreDriver.swift#L47

On Android, where does it create the keystore? https://github.com/berty/berty/blob/b323168b99005c759f5db1231830ac827396578a/js/android/app/src/main/java/tech/berty/gobridge/KeystoreDriver.java#L40

jefft0 avatar Oct 20 '23 09:10 jefft0

We don't have enough info right now to understand how the key store is saving data using the OS features. Put in backlog until we have time to investigate.

jefft0 avatar Oct 27 '23 14:10 jefft0

I think this issue was about the key not being removed on account delete, not app removal

n0izn0iz avatar Oct 27 '23 16:10 n0izn0iz

Thanks, @n0izn0iz! I updated the comment.

jefft0 avatar Oct 27 '23 16:10 jefft0