core icon indicating copy to clipboard operation
core copied to clipboard

feat(rest): first implementation

Open Mte90 opened this issue 3 years ago • 9 comments

Ref: https://github.com/berlindb/core/issues/26

For an example to test it https://github.com/Mte90/berlindb-rest/

I will update the example when will be merged https://github.com/berlindb/wordpress-example

Mte90 avatar Jul 08 '22 11:07 Mte90

I was thinking too that some redefine like for the table etc wasn't necessary but this library just extend various classes and they are not connected each other so those data are not shared. So in the meantime the patch let everything to work and those changes require some internals changes in BerlinDB that I think it's not the case to discuss here (to keep the focus on the REST stuff, maybe open a ticket for that?).

During the development of this integration I saw this issue in that PR:

  • my naming capability and documentation skills are not the best one
  • I don't know so much core internals to expose other data on the endpoints but I think that maybe release the support just for a subset of stuff is not a problem to see how works etc
  • the read function needs a little bit of love to improve it
  • I didn't added anything for escaping/sanitization as I see that BerlinDB already does but I am not sure...

Mte90 avatar Jul 11 '22 08:07 Mte90

I was forgetting a little things, I just configured the doc comments for 3.0.0 release.

I still waiting for a review as I am curious for feedback :-D

Mte90 avatar Jul 18 '22 07:07 Mte90

In the meantime I am using my fork in a plugin I am working on, so I have another test field.

Mte90 avatar Jul 21 '22 10:07 Mte90

Haven't forgotten about this. 👋

Just been busy working on other 3.0 changes to hopefully make your work easier to merge/adopt. 🍕

JJJ avatar Sep 07 '22 12:09 JJJ

Thanks I just used BerlinDB in this period #23 as per that ticket and I think that the example need improvements until the documentation is not out there.

Mte90 avatar Sep 07 '22 12:09 Mte90

just a ping

Mte90 avatar Nov 08 '22 18:11 Mte90

Can't wait to see this merged too. If you need some help to run tests or everything ✋🏻✋🏻✋🏻

mircobabini avatar Dec 17 '22 10:12 mircobabini

ping

Mte90 avatar Jun 27 '23 16:06 Mte90