core icon indicating copy to clipboard operation
core copied to clipboard

Release/2.1.0 - WIP

Open JJJ opened this issue 4 years ago • 7 comments

Work in progress!

JJJ avatar Aug 31 '21 02:08 JJJ

Once this was a gift for a WP plugin developer: https://gist.github.com/szepeviktor/ddb1bfd12d93accd318cc081637956ec

szepeviktor avatar Jul 02 '22 19:07 szepeviktor

Once this was a gift...

Yes! Berlin will absolutely benefit from exactly this kind of abstraction.

See also: #39 🤧

JJJ avatar Jul 02 '22 22:07 JJJ

See also: #39 🤧

I see #69 also.

szepeviktor avatar Jul 02 '22 23:07 szepeviktor

As this change is very big could it be named v3?

szepeviktor avatar Jul 05 '22 11:07 szepeviktor

As this change is very big could it be named v3?

I was thinking about this, too. Probably yes, IMO.

JJJ avatar Jul 05 '22 16:07 JJJ

On PHP 8.0

composer update
vendor/bin/phpstan analyze src/ --level=1

Please ignore apply_filters invoked with 3 parameters.

On lower levels PHPStan will complain about PHPDoc blocks, on higher levels you get your rewards 💎 💎 💎

szepeviktor avatar Jul 05 '22 17:07 szepeviktor