redirects not followed when streaming the request body

[jfis]

maybe this is intentional, or I'm missing something?

v 1.2.0 please forgive elixir syntax, not sure how to load hackney into erl

normal request returns redirect

iex(1)> :hackney.request(:get, "http://rdrct.herokuapp.com/1", [], "", [])
{:ok, 301,
 [{"Connection", "keep-alive"}, {"Server", "Cowboy"},
  {"Date", "Thu, 16 Jul 2015 23:48:48 GMT"}, {"Content-Length", "0"},
  {"Location", "/2"}, {"Via", "1.1 vegur"}], #Reference<0.0.0.3698>}

with follow redirect

iex(1)> :hackney.request(:get, "http://rdrct.herokuapp.com/1", [], "", [follow_redirect: true, max_redirect: 5])
{:ok, 200,
 [{"Connection", "keep-alive"}, {"Server", "Cowboy"},
  {"Date", "Thu, 16 Jul 2015 23:42:13 GMT"}, {"Content-Length", "2"},
  {"Via", "1.1 vegur"}], #Reference<0.0.0.3263>}

with stream request body

iex(1)> {:ok, client} = :hackney.request(:get, "http://rdrct.herokuapp.com/1", [], :stream, [follow_redirect: true, max_redirect: 5])
iex(2)> :hackney.start_response(client)
{:ok, 301,
 [{"Connection", "close"}, {"Server", "Cowboy"},
  {"Date", "Thu, 16 Jul 2015 23:51:47 GMT"}, {"Content-Length", "0"},
   {"Location", "/2"}, {"Via", "1.1 vegur"}], #Reference<0.0.0.3895>}

post

iex(3)> {:ok, client} = :hackney.request(:post, "http://rdrct.herokuapp.com/1", [], :stream, [force_redirect: true, follow_redirect: true, max_redirect: 5])
iex(4)> :hackney.send_body("test")
iex(5)> :hackney.start_response(client)
{:ok, 301,
[{"Connection", "close"}, {"Server", "Cowboy"},
 {"Date", "Fri, 17 Jul 2015 16:37:04 GMT"}, {"Content-Length", "0"},
 {"Location", "/2"}, {"Via", "1.1 vegur"}], #Reference<0.0.0.2196>}

(destination taken from https://github.com/benoitc/hackney/issues/170)

[benoitc]

You should go next to actually redirect the reauest. Redirection should probably handled before though. It will be fixed in the next release.

[benoitc]

Did some test. I was wrong. Since you are streaming the body, it's not kept around and there are no way yet to resend it. So the status is simply returned and you should handled the redirection by yourself.

At that point I am not sure what to do:

1. Keep the current way, ie simply return the status.
2. As above but to ease the work we may want to retrieve directly the body and release the socket directly. The response would be then {ok, 301, Headers, Body}.
3. Log the request and replay the stream. The issue with that is that we would need to keep a log for all streamed requests which will impact the RAM or disk eventually.

Thoughts?

[jfis]

i think it's probably best to keep it as is and not allow :stream with :follow_redirect, but it should be noted in the docs

[benoitc]

why did you close the issue?

[jfis]

oh i'm sorry if i shouldn't have. i came across this on some feed and saw it was 5 years old and still open. i thought maybe you were waiting on me to close it or it was overlooked. i'll leave it be.