Benoit Chesneau

Results 726 comments of Benoit Chesneau

@mocchira yes this si exactly what I was thinking of, thanks for the summary :) If it's OK i will work on that. I should have a patch until monday...

since I have implemented https://github.com/benoitc/erocksdb/commit/49978f74aa29a5a6c4f817b1d1cfba367e0d3905 which is using the new checkpoint feature. It's quite more efficient and used by the mysql version of facebook that uses rocksdb. Let me know.

@mocchira the code have been tested on OX and linux. not yet on freebsd. About the implementation obviously it would be better to implement the backup as an asynchronous task....

mmm i would be interrested to fix it. How could I test easily?

I will check. In the mean time can you try the patch below? ``` diff diff --git a/c_src/build_deps.sh b/c_src/build_deps.sh index 107b6ae..1752301 100755 --- a/c_src/build_deps.sh +++ b/c_src/build_deps.sh @@ -67,7 +67,7 @@...

ah forgot it for the unittests( the section above in the Makefile). Shouldn't be hard anyway, probably just a flag.

Hi, I tested on the node you gave me and went a little further in building erocksdb by doing the following: 1) set PATH to point to the gcc binaries:...

same error but I came to a simpler patch: ``` diff diff --git a/c_src/build_deps.sh b/c_src/build_deps.sh index 71e36bc..69ffbf7 100755 --- a/c_src/build_deps.sh +++ b/c_src/build_deps.sh @@ -8,7 +8,7 @@ if [ `uname -s`...

@mocchira maybe we could have some support for custom patches to the erocksdb build? All patches would be in a patches directory and applied one by one on the rocksdb...

I will this week. One question still, how much differs your fork of cowboy from the official? Can't patches be done upstream?