Benoit Chesneau comments

Results 726 comments of


                                            Benoit Chesneau

use 'unite' for eunit error formatting

Thanks for the patch. Is unite available on hex? I would prefer to pass a source package name instead

use 'unite' for eunit error formatting

@eproxus did you manage to have pre-18 support?

add test case for broken https proxying

thanks! That will help for the fix :)

URL params in relative redirect URL get mangled

Right. I should use the raw path and just append it probably. I will have a look in the next version. However please note that the Location should be an...

Proxy configuration not used when using follow_redirect

@edgurgel I need to write a test for it. Maybe we could use [mitmproxy](https://mitmproxy.org/) for it ? What do you think?

Proxy configuration not used when using follow_redirect

@edgurgel that would be very helpful. I will wait over the week-end then and work on other parts :)

"Unexpected message" error log and then requests stopped

Yes, it's a message not vatched by hackney (though it should be in last version. There is a new connection handling that will be part of the next update fixing...

"Unexpected message" error log and then requests stopped

@losvedir can you share a snippet of your code doing the request and where you get that error?

Fix ssl_closed message leak when server hangs up ("Connection: close" header)

i didn't cherry-picked :) I merged your other PR #641 . I didn't merge this one yet as i wanted to test it first. There will be a new release...

Fix ssl_closed message leak when server hangs up ("Connection: close" header)

Sorry to have been silent. There is a new release coming next week that will fix this issue. I will create a ticket summarizing it. On Mon 28 Dec 2020...