ember-routable-modal issues

Doesn't work with Ember FastBoot

The checks in the `current-routed-modal` service fail in FastBoot mode. This seems to be because the checks are merely looking whether `$` or `window` are undefined, but it seems to...

courthead

Override Modal Close Functionality

1

Hey! I love this addon and it has been easy to work with, but I've got a question. I'm currently using a modal that handles a user creation form for...

ryanjavens

Using outlet within routable modal doesn't render

1

I've tried adding an outlet within my modal so that I can create steps for creating an order, eg. order/create/details, order/create/items The outlet doesn't seem to render when navigating via...

jason-duvenage

Loading State

Hi, we´ve got an weired behaviour opening a routed modal with a model hook. There are 2 routed modals. One without a model hook (MR1) and one with a model...

Fabschu

Fixing service to allow scrolling of test results

Also cleaned up memory leak.

gmurphey

Idea: use ESC key to leave modal

Just an idea. Not sure if this should be part of the ember addon itself or in the code that uses the addon?

stephanebruckert

currentRouteName assertions fail in tests when afterModel block runs in route mixin

Here's a branch with failing tests illustrating the issue: https://github.com/metricly/ember-routable-modal/tree/current-route-name-test-failures It seems that the transition isn't completed when the modal isn't the route used for the initial transition. https://github.com/dbbk/ember-routable-modal/blob/134d665fcd1912331f766e09f9db2c8987c1e7ee/addon/mixins/route.js#L58-L76

gmurphey

Option to disable routing

1

This might sound like a weird suggestion, but it would be nice to have an option to make a modal non-routable (basically being able to disable the primary feature of...

stephanebruckert