retlab icon indicating copy to clipboard operation
retlab copied to clipboard
verified publisher icon benbalter

Google analytics got dropped

Open deargle opened this issue 4 years ago • 1 comments

Not necessarily a bad thing, but it is an undocumented thing.

Commit https://github.com/benbalter/retlab/commit/5a8f63860934ab8bbc31a3030bf2bb0118a8a52a dropped google_analytics, but _config.yml still includes ga_username. Should an if-block be added back in to _layouts/default.html, or should ga_username be removed from the config?

deargle avatar Dec 16 '21 16:12 deargle

@deargle thanks for opening the issue. I no longer use Google Analytics, but if you'd like support for it, I'm happy to review a PR that adds it conditionally if ga_username is set.

benbalter avatar Dec 16 '21 16:12 benbalter