VRCFaceTracking icon indicating copy to clipboard operation
VRCFaceTracking copied to clipboard

CVR support

Open NovaVoidHowl opened this issue 3 years ago • 7 comments

This merge request is to allow for smoother interaction between CVR (via OSC mod) and this app. It adds the following features

  • auto operating mode detection (if target app is open already)
  • manual operating mode selection via --opmode option for start up

(note this version also includes all the features from my prior merge request (https://github.com/benaclejames/VRCFaceTracking/pull/94) so as/when this gets merged, that should be closed too)

NovaVoidHowl avatar Nov 26 '22 15:11 NovaVoidHowl

~~note compiled version for this can be found at https://github.com/NovaVoidHowl/VRCFaceTracking/releases/tag/v4.1.0~~

NovaVoidHowl avatar Nov 26 '22 15:11 NovaVoidHowl

Hey, your comments don't seem to correlate with file changes. Maybe you forgot to commit some of the features? I'm only seeing the changes for port selection launch parameters and help launch params, am I missing something? Thanks

benaclejames avatar Nov 26 '22 19:11 benaclejames

@benaclejames , sorry about that I had committed the changes to the wrong branch at my end, the above commit should include all the new changes.

NovaVoidHowl avatar Nov 26 '22 20:11 NovaVoidHowl

just putting a hold on this merge, rebuilt it just now (using totally up-to-date branch data from your repo) and can see some further issues

NovaVoidHowl avatar Nov 26 '22 21:11 NovaVoidHowl

@benaclejames , Ok further error fixes added to support current main branch from your repo, tested and working just now Hopefully it will pass your testing too.

NovaVoidHowl avatar Nov 26 '22 23:11 NovaVoidHowl

note compiled version for this can be found at https://github.com/NovaVoidHowl/VRCFaceTracking/releases/tag/v4.2

NovaVoidHowl avatar Nov 26 '22 23:11 NovaVoidHowl

Hey, sorry for the late reply.

We've been discussing the future of VRCFT internally for quite a while now and merging compatibility for another game raises some questions as to what the true purpose of VRCFT is as an application.

We're currently waiting on @regzo2's new PRs to be finished to remove any SRanipal compatibility and will then most likely be pivoting to VRCFT becoming a parameter processing framework for VR in general as opposed to VRChat. I'll get back to you when we start introducing these changes and talks get further regarding them.

Sorry to have kept you in the dark 💙

benaclejames avatar Jan 21 '23 22:01 benaclejames