push icon indicating copy to clipboard operation
push copied to clipboard

feat(push): delete FCM token and unregister iOS PN + remove streams API

Open ben-xD opened this issue 2 years ago • 4 comments

I made another breaking change to make things consistent (all callback API, no streams). ~~Should I make that v3 or v2.1 😅️?~~ I'll make it v3.

Fixes https://github.com/ben-xD/push/issues/46

TODOs

  • [ ] Documentation for usage (docstrings in the public classes)
  • [ ] Add examples to example app
  • [ ] Update docs to be v3 breaking changes
  • [ ] Release

ben-xD avatar Jan 22 '24 09:01 ben-xD

Hi @ben-xD , when do you plan to release v3?

PiotrWpl avatar Jun 03 '24 07:06 PiotrWpl

It's been on my mind, I'd like to remove the streams API asap. I'll spend some time on it on the evenings this week 🙏🏼️

ben-xD avatar Jun 03 '24 13:06 ben-xD

You are a true angel! Thank you 💪

PiotrWpl avatar Jun 03 '24 17:06 PiotrWpl

Any updates for this?

PhantomRay avatar Aug 02 '24 02:08 PhantomRay

Hi @ben-xD do you have any update here?

PiotrWpl avatar Jan 10 '25 11:01 PiotrWpl

Sorry i forgot about this. I'll take a look now

ben-xD avatar Jan 10 '25 20:01 ben-xD

Thanks a lot for the great work!

But I noticed that this is not mentioned in changelog.

PhantomRay avatar Jan 11 '25 02:01 PhantomRay

Sorry @PhantomRay, the FCM side is done. I'm gonna do the Apple one today, after removing the "federation"/tediousness of the repo, to improve developer experience. The PR was getting too big.

I've reopened https://github.com/ben-xD/push/issues/46

ben-xD avatar Jan 11 '25 10:01 ben-xD

Sorry i forgot about this. I'll take a look now

Thank you!

PiotrWpl avatar Jan 12 '25 08:01 PiotrWpl

@PhantomRay, I added the register/unregister in 3.2.0

ben-xD avatar Jan 12 '25 20:01 ben-xD