bemuse icon indicating copy to clipboard operation
bemuse copied to clipboard
verified publisher icon bemusic

Refactor GameDisplay

Open MikuroXina opened this issue 3 years ago • 4 comments

For types, @types/jquery is added and screenfull is bumped.

MikuroXina avatar Jan 08 '23 09:01 MikuroXina

Codecov Report

Base: 86.39% // Head: 86.21% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (9e8dcce) compared to base (68e0d52). Patch coverage: 71.54% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   86.39%   86.21%   -0.19%     
==========================================
  Files         178      178              
  Lines        5366     5374       +8     
  Branches      382      426      +44     
==========================================
- Hits         4636     4633       -3     
- Misses        676      682       +6     
- Partials       54       59       +5
Impacted Files Coverage Δ
bemuse/src/game/display/touch3d.ts 6.66% <0.00%> (ø)
bemuse/src/game/state/player-state.ts 86.07% <ø> (ø)
bemuse/src/game/display/player-display.ts 71.30% <71.30%> (ø)
bemuse/src/game/display/Gauge.ts 100.00% <100.00%> (ø)
bemuse/src/game/display/note-area.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jan 08 '23 09:01 codecov-commenter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 08 '23 09:01 sonarqubecloud[bot]

@dtinth Excuse me, could you review my PR? I forgot this.

MikuroXina avatar Aug 11 '23 10:08 MikuroXina

@MikuroXina Hello, I really apologize. I am currently very occupied with other stuff right now and probably do not have time to develop this project for a few months. 🙏

From a quick glance the code looks good to me, although I can’t play-test the game right now.

For the time being, please feel free to publish a forked version, and feel free to ask me if you need any help.

dtinth avatar Aug 13 '23 06:08 dtinth