bem-react-components icon indicating copy to clipboard operation
bem-react-components copied to clipboard

Use new version of bem-tools-create

Open veged opened this issue 8 years ago • 7 comments

Close #12

veged avatar Mar 25 '17 19:03 veged

@tadatuta can we already use bem-create by level templates?

awinogradov avatar May 19 '17 14:05 awinogradov

@awinogradov

can we already use bem-create by level templates?

not sure what are you asking about but this PR looks good to me

tadatuta avatar May 19 '17 18:05 tadatuta

I mean we want to use different templates for different levels

Best regards

Anton Winogradov [email protected]

On 19 May 2017, 21:06 +0300, Vladimir Grinenko [email protected], wrote:

@awinogradov (https://github.com/awinogradov)

can we already use bem-create by level templates?

not sure what are you asking about but this PR looks good to me

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/bem/bem-react-components/pull/13#issuecomment-302772438), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA78OJyqKPigGEgvRNVhknZEVq_9XkQ8ks5r7do3gaJpZM4MpMUq).

awinogradov avatar May 19 '17 18:05 awinogradov

yes, it should work

tadatuta avatar May 19 '17 18:05 tadatuta

@tadatuta we fix templates and try to do bem create Test (which create all as suppose) and bem create -l blocks/Test/Test.tests simple (which do not create anything) — looks like 'blocks/**/*.tests' in .bemrc.js do not match and affect creation

veged avatar Sep 01 '17 13:09 veged

@veged that's true 'coz current implementation of glob expansion uses glob module which looks for real folders on FS.

I created https://github.com/bem-tools/bem-tools-create/issues/52 to support current case but can't say if it can be implemented soon.

Right now the only way to go is to create blocks/Test/Test.tests manually or add it as one of the block's tech (so that bem create Test call with create Test.{css,js,tests}).

tadatuta avatar Sep 01 '17 20:09 tadatuta

@tadatuta actually there is the similar problem if directory blocks/Test/Test.tests already exists — bem create will create only default techs (not ones those configured for 'blocks/**/*.tests')

veged avatar Sep 04 '17 09:09 veged