Behdad Esfahbod

Results 1496 comments of Behdad Esfahbod

> > `Zmth` is correct. > > "Correct" regarding to which reference? I mean, the return value of `unicodedata.ot_tag_to_script` for `math` should be `Zmth`. That's what HarfBuzz uses.

@madig does this work for you: ```diff diff --git a/Lib/fontTools/unicodedata/OTTags.py b/Lib/fontTools/unicodedata/OTTags.py index a9d8cd1ce..ba25cfba1 100644 --- a/Lib/fontTools/unicodedata/OTTags.py +++ b/Lib/fontTools/unicodedata/OTTags.py @@ -22,6 +22,7 @@ SCRIPT_EXCEPTIONS = { "Yiii": "yi ", "Nkoo": "nko...

@anthrotype What's your appetite for this branch?

> before I begin to review, I was wondering what's the plan with this. Are you planning on keeping it as a separate branch (occasionally rebased on main) while the...

> TTFont.save already saves to a temporary stream which takes care of the problem with overwriting input file I highly strongly whatever suggest that TTFont.save be changed to save to...

> I highly strongly whatever suggest that TTFont.save be changed to save to a temporary _file_ and then _rename_ that file to final destination. That's the only way to ensure...

> windows can't delete an open file I don't see a problem if, on windows, output file has to be different.

Although, maybe we should implement the DWrite logic instead, which wouldn't need to pass down the nameID. I'm not sure.