beets icon indicating copy to clipboard operation
beets copied to clipboard

Minor improvements to deezer plugin typing.

Open semohr opened this issue 8 months ago • 1 comments

Description

Added some more typehints to deezer plugin.

I know, it is properly not used much and we don't even have test for the deezer plugin but I want to make this a bit more maintainable, mainly to prepare for https://github.com/beetbox/beets/pull/5787 and make migration a bit easier.

semohr avatar Jun 02 '25 11:06 semohr

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

github-actions[bot] avatar Jun 02 '25 11:06 github-actions[bot]

Not sure if you've seen my review comment

Would it be possible to isolate method moves into a separate commit? It's a bit complicated to see the relevant changes when the entire method implementations are red and green 😅

Would you be happy to do so?

snejus avatar Jun 22 '25 17:06 snejus

Not sure if you've seen my review comment

Would it be possible to isolate method moves into a separate commit? It's a bit complicated to see the relevant changes when the entire method implementations are red and green 😅

Would you be happy to do so?

Sure, the moves should now be contained in one commit. I also added that one to the .git-blame-ignore-revs

semohr avatar Jun 24 '25 15:06 semohr