beets icon indicating copy to clipboard operation
beets copied to clipboard
verified publisher icon beetbox

Support XDG user directories

Open bal-e opened this issue 1 year ago • 1 comments

Description

Fixes #5168. A simple parser for user-dirs.dirs has been implemented, and it is used to change the default music directory path when beets.Library is initialized.

To Do

  • [x] ~Documentation~
  • [x] Changelog
  • [x] Tests

bal-e avatar Jun 25 '24 15:06 bal-e

I don't love writing (example-based) tests, so there aren't many right now. If you'd like to see some more, let me know.

bal-e avatar Jun 25 '24 15:06 bal-e

Have you considered using platformdirs?

snejus avatar Jul 13 '24 18:07 snejus

Have you considered using platformdirs?

Oh shoot, I hadn't realized that was a thing. I had searched around PyPi for XDG related libraries, but this one hadn't come up for some reason. I think it's best for me to close this PR and open a new one which just uses platformdirs, instead of trying to modify this one in place.

bal-e avatar Jul 14 '24 08:07 bal-e

Have you considered using platformdirs?

Oh shoot, I hadn't realized that was a thing. I had searched around PyPi for XDG related libraries, but this one hadn't come up for some reason. I think it's best for me to close this PR and open a new one which just uses platformdirs, instead of trying to modify this one in place.

Yeah I remember it took me a while to discover it exists as well! Sounds like a good approach.

snejus avatar Jul 14 '24 12:07 snejus

I'll close this, as you suggested @bal-e

Serene-Arc avatar Jul 18 '24 05:07 Serene-Arc