beets icon indicating copy to clipboard operation
beets copied to clipboard

autotagger: match file name if the file has no title metadata

Open mklein-de opened this issue 1 year ago • 2 comments

This improves autotagging of items without metadata

  • [x] ~Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)~
  • [x] Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • [x] Tests. (Very much encouraged but not strictly required.)

mklein-de avatar Mar 16 '24 19:03 mklein-de

We already have a fromfilename plugin. Does this add any additional features?

arsaboo avatar Oct 04 '24 21:10 arsaboo

We already have a fromfilename plugin. Does this add any additional features?

ah, didn't see the plugin... This doesn't add any feature, except that it work in the default configuration without any plugins enables

mklein-de avatar Oct 05 '24 17:10 mklein-de

I have mixed feelings about this change. Currently, when I try to import a file that has no metadata, I can instantly see what's going on: there are 0 results, and I see in the logs that artist/album fields are empty.

If we default to the filename, the autotagger may return some results, but the logs won't make it clear that the tags in the file were empty. Those results will not be relevant for any other filename except when it has the title.

snejus avatar Dec 08 '24 14:12 snejus

I think if we have the plugin, we shouldn't add this to the base code. Besides, that plugin is actually packaged with beets. You don't have to install it so much as enable it. Thanks for the PR @mklein-de but I think this isn't needed. Even if we were to merge this, we would probably have to have a configuration option governing it anyway, so it wouldn't actually change the user experience. If you think we should include the fromfilename plugin in the default configuration for beets, that's another PR.

Serene-Arc avatar Dec 10 '24 05:12 Serene-Arc