poly icon indicating copy to clipboard operation
poly copied to clipboard

Certain tests fail on windows

Open toothsy opened this issue 2 years ago • 4 comments

Describe the bug Hello,I'm a windows user and I cloned the repo locally, installed all the vscode extensions, and ran all the tests, some test cases failed

To Reproduce Steps to reproduce the behavior:

  1. have a windows Operating system
  2. clone the repo locally
  3. run it in VSC
  4. run all tests

Expected behavior all tests must be green but some failed

Screenshots image

Desktop:

  • OS: [Windows]

Additional context upon closer inspection in gff_test.go

  • image
    • atoiFn is getting "6370\r" as its input hence it is panics
  • the newline error due to windows is causing the issue

toothsy avatar Mar 23 '23 07:03 toothsy

Once #340 is merged, this will be an easy fix.

carreter avatar Sep 12 '23 17:09 carreter

Also @toothsy could you inspect the data being read in by the tests and let us know what the line endings are on Windows? You can do this using git ls-files --eol, please post the output of that here. Would do it myself but I don't have a Windows computer.

carreter avatar Sep 12 '23 19:09 carreter

Bumping this. If anyone has access to a Windows machine, info would be greatly appreciated! Worst case I can spin up a VM, but I'm lazy...

carreter avatar Sep 23 '23 23:09 carreter

This issue has had no activity in the past 2 months. Marking as stale.

github-actions[bot] avatar Dec 01 '23 18:12 github-actions[bot]