Florent Beaurain comments

Repositories
Issues
Comments

Results 14 comments of


                                            Florent Beaurain

`rack.request` span that are stopped in middleware or before action doesn't have resource set

> > our custom code that set a service to a rack.request based on the resource > That's interesting, does this mean you're overriding the rack.request span service name? Yes,...

`ActiveSupport::Cache#read_multi` is not instrumented when using `ActiveSupport::Cache::RedisCacheStore`

Clearly linked. But in our case that's the other way around, as we have rails > 5.2 and don't use `activesupport-redis`, that's what I wanted to put in light. In...

Report ActiveSupport::LogSubscriber errors to Rails.error

@zzak oupsi! Sorry about that! Now fixed. I haven't added a CHANGELOG entry, I'm not sure it's needed for this kind of change?

DB connection pool size

Hey @rosa! Sorry for not coming back to you. I think @kersuzananthony tried your suggestion and it worked perfectly! Thanks again 🙏