openWAR icon indicating copy to clipboard operation
openWAR copied to clipboard

make shakeWAR faster

Open beanumber opened this issue 10 years ago • 2 comments

beanumber avatar May 28 '15 17:05 beanumber

Note that a call to shakeWAR with n resamples results in getRAA being called 2n+2 times.

owar <- shakeWAR(MayProcessed, N = 1)
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...

The 2n is because each call to getWAR calls getRAA twice: once for the replacement-level players and once for all of the players. [Is this necessary?]

Where do the extra 2 calls to getRAA come from?

beanumber avatar Jun 17 '15 18:06 beanumber

If the replacement data and the current year data are different, I think you will have to call getRAA twice. If the current data is used for both calculation and carbonising of replacement it should only call it once. On Jun 17, 2015 1:52 PM, "Ben Baumer" [email protected] wrote:

Note that a call to shakeWAR with n resamples results in getRAA being called 2n+2 times.

owar <- shakeWAR(MayProcessed, N = 1) ...Tabulating RAA per player... ...Tabulating RAA per player... ...Tabulating RAA per player... ...Tabulating RAA per player...

The 2n is because each call to getWAR calls getRAA twice: once for the replacement-level players and once for all of the players. [Is this necessary?]

Where do the extra 2 calls to getRAA come from?

— Reply to this email directly or view it on GitHub https://github.com/beanumber/openWAR/issues/42#issuecomment-112912704.

gjm112 avatar Jun 17 '15 19:06 gjm112