Constructing pointwise mutual information directly from sparse matrix

Open kaushikacharya opened this issue 5 years ago • 2 comments

In R/word2vec_fit.R # construct_pmi() do we really need to convert input sparse matrix into a regular matrix? As more and more CUIs are considered, this will lead to exceeding the memory limit of the m/c.

I have made changes in my forked repo to construct pmi directly using sparse matrix: https://github.com/kaushikacharya/cui2vec/commit/c33492d3eedf293c5348b10a68f7677490dbd6a4

If you want I can create a pull request.

Mar 04 '20 06:03 kaushikacharya

Hi there,

Thanks for your interest in the project -- your fork looks great. We'd welcome a PR.

Apr 08 '20 23:04 bkompa

@bkompa Pull Request created: https://github.com/beamandrew/cui2vec/pull/2

May 13 '20 16:05 kaushikacharya