pauls-dat-api icon indicating copy to clipboard operation
pauls-dat-api copied to clipboard
verified publisher icon beakerbrowser

update package to include babel-polyfill as dependency

Open e-e-e opened this issue 8 years ago • 2 comments

I just realised that the es5 compatibility that I added a few months ago is broken for anyone who does not have babel-polyfill in their package. This is a simple fix to remedy that problem. Sorry for the silly mistake.

e-e-e avatar Jul 06 '17 12:07 e-e-e

I appreciate the PR! But I'm not super enthusiastic about including those deps in my projects, since I don't use es5. Is there any way we can do this differently?

pfrazee avatar Jul 06 '17 13:07 pfrazee

I completely understand. I was kind of surprised that babel expects such dependency after already transpiling the code - seems poor practice. I did a bit of research on how to avoid it and could not find anything obvious, but let me have another look. Perhaps now node 6 is LTS we could just increase es5 to es6 which I don’t think would require the polyfill for promises, etc.

e-e-e avatar Jul 06 '17 14:07 e-e-e