reactackle icon indicating copy to clipboard operation
reactackle copied to clipboard

Accessibility best practices seem to not be present

Open ryanflorence opened this issue 8 years ago • 1 comments

I spent a minute or two and found several accessibility issues with the components immediately, for example:

  • not trapping tab navigation in dialogs
  • no aria attributes on checkboxes
  • missing outline/active styles on checkboxes, buttons, etc.
  • arrow buttons don't change Select dropdown choices
  • focusing other elements doesn't close custom select dropdowns

This signals to me that you folks haven't done much with accessibility (that's fine, few have). Or maybe you're just saving that work for later (good luck, that usually doesn't go well 😑).

I don't have time to do a full audit, and the amount of code that needs to change is probably pretty considerable. So I'm opening this issue to point you to a document that can help you dive deeper into accessibility.

https://www.w3.org/TR/wai-aria-practices-1.1/

I'd just encourage you to spend a day studying this document, then implement the proper attributes and behavior to create a more accessible web. If your components aren't highly accessible, you've only done half the job of a library like this 🤗

ryanflorence avatar Aug 02 '17 14:08 ryanflorence

Thanks for the feedback! Yep, we know about the accessibility problems and agree about the importance of it 😔. And so are going to fix it component-by-component.

netmenya avatar Aug 02 '17 15:08 netmenya