CodeIgniter icon indicating copy to clipboard operation
CodeIgniter copied to clipboard

missing php extensions in composer.json

Open tenzap opened this issue 3 years ago • 3 comments

I noticed that the framework uses ctype_*, mb_*, hash_*, json_*, session_* which are part of the ctype, mbstring, json, session & hash extensions.

These extensions are not in the composer.json require section.

    "require": {
....
        "ext-ctype": "*",
        "ext-hash": "*",
        "ext-json":  "*",
        "ext-mbstring": "*",
        "ext-session":  "*",

Maybe it would be good to add them?

tenzap avatar Mar 05 '22 17:03 tenzap

Well, yes and no.

One could use the framework without the need for any of the above extensions, as they are used in certain files. For those, the composer installation could fail if they lack at least one of the mentioned PHP extensions in require.

gxgpet avatar Mar 06 '22 08:03 gxgpet

Maybe then put it in "suggest"? I saw mbstring and iconv are not mandatory. The others depend on whichever lib of ci is used?

tenzap avatar Mar 07 '22 06:03 tenzap

I saw mbstring and iconv are not mandatory. The others depend on whichever lib of ci is used?

I think currently is not really mandatory to require those in composer. CI is very flexible on this

otengkwame avatar Jul 31 '22 20:07 otengkwame