wps icon indicating copy to clipboard operation
wps copied to clipboard

Upgrade React 17 to 18

Open conbrad opened this issue 3 years ago • 2 comments

Describe the task Upgrade react from v17 to v18 and test/fix any issues in our products.

Acceptance Criteria

  • [ ] Upgrade react, react-dom and testing-library
  • [ ] Upgrade typings fore react and react-dom
  • [ ] All products work after the upgrade
  • [ ] Also upgrade testing-library: https://github.com/bcgov/wps/pull/2287, https://github.com/bcgov/wps/pull/2654
  • [ ] Fix issue with esri-leaflet not compiling with webpack (eject cra? migrate to vite? kill chaines?)

Additional context

  • Associated renovate PRs:
  • https://github.com/bcgov/wps/pull/1844
  • https://github.com/bcgov/wps/pull/1843
  • https://github.com/bcgov/wps/pull/1842
  • https://github.com/bcgov/wps/pull/2289
  • https://github.com/bcgov/wps/pull/2290

conbrad avatar Apr 04 '22 15:04 conbrad

Hey team! Please add your planning poker estimate with Zenhub @andrea-williams @dgboss

NicolasLivanos avatar Apr 12 '23 21:04 NicolasLivanos

HFI Calculator keeps reloading components after this update, most likely due to the changes to StrictMode in React 18. Possibly fix: https://react.dev/learn/synchronizing-with-effects#how-to-handle-the-effect-firing-twice-in-development

conbrad avatar Jun 15 '23 00:06 conbrad

Done

conbrad avatar Aug 22 '24 23:08 conbrad