entity icon indicating copy to clipboard operation
entity copied to clipboard

Auth Web staff dashboard: submitter should not be "undefined"

Open severinbeauvais opened this issue 1 year ago • 5 comments

The original submitter name shows as "undefined".

The re-submitter name is not even shown.

image.png

The root cause is that we no longer capture the Completing Party as this is an authorization only -- but we do have the submitter's login. (Note that we also don't support multiple submitters.)

Option 1: Show the authorization submitter from the filing's header.submitter property. (Right now this is the encoded login but we could update the review endpoint to provide the decoded name.) We would only be able to display one submitter -- the original one or the latest one. I suggest the latest one as being most useful.

Option 2: Don't show the authorization submitter, since we already don't show it for a resubmission.

severinbeauvais avatar Oct 28 '24 22:10 severinbeauvais

Duplicate ticket: #24078

severinbeauvais avatar Oct 29 '24 22:10 severinbeauvais

Also, the line should say "Authorization Submitted" (not Application).

severinbeauvais avatar Oct 31 '24 17:10 severinbeauvais

@jacqueline-williams-549 @janisrogers Please see the description for possible options. Do you have a preference? Thanks!

severinbeauvais avatar Oct 31 '24 20:10 severinbeauvais

My preference would be option 1, but I am okay with option 2.

janisrogers avatar Oct 31 '24 23:10 janisrogers

@OlgaPotiagalova Could you please decide whether we should implement option 1 or option 2?

Option 1 is more work (est: 1 for UI, 2 for API) but provides a better experience because it should the submitter name.

Option 2 is almost no work (est: 1 for UI).

severinbeauvais avatar Nov 01 '24 23:11 severinbeauvais

Blocked while awaiting PO decision.

severinbeauvais avatar Nov 27 '24 19:11 severinbeauvais

Considering the release timeline and the effort, please implement solution 2 for now.

Create a separate ticket(s) to capture the submitter information (from login account), model it in the db, and display it in the staff dashboard, for future implementation.

OlgaPotiagalova avatar Jan 03 '25 19:01 OlgaPotiagalova

@ArwenQin Please work on this ticket. See comments above for the decisions we made.

severinbeauvais avatar Jan 09 '25 20:01 severinbeauvais

Created #25230 for future implementation.

ArwenQin avatar Jan 09 '25 22:01 ArwenQin

Deployed to PROD, this is low risk (small wording change see PR https://github.com/bcgov/sbc-auth/pull/3202 also I don't think continuation IN is active on PROD).

seeker25 avatar Jan 20 '25 20:01 seeker25