entity Legal API: fix alteration of company type issues

See results from #23941.

Steps to Reproduce:

Open a BC numbered business (impacting regular and continued-in) Start a business type alteration. Select BC Community Contribution Company from dropdown (i.e. try to alter BC -> CC or C -> CCC). Proceed with regular filing workflow. Click File and Pay button. Unable to save Filing error pop-up appears.

Oct 25 '24 16:10 severinbeauvais

Steps to Reproduce:

Open a BC numbered business (impacting regular and continued-in)
Start a business type alteration.
Select BC Community Contribution Company from dropdown (i.e. try to alter BC -> CC or C -> CCC).
Proceed with regular filing workflow.
Click File and Pay button.
Unable to save Filing error pop-up appears.

Alteration attempted on BC0883647 from screenshots.

Oct 29 '24 22:10 meawong

Here are the updated requirements.

BC -> BEN
BC -> ULC
BC -> CC
BEN -> BC
BEN -> CC
ULC -> BC
ULC -> BEN

(and all the continued-in equivalents)

Nov 01 '24 20:11 severinbeauvais

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

Nov 12 '24 21:11 vysakh-menon-aot

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

How about another sync ticket?

Nov 12 '24 21:11 severinbeauvais

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

How about another sync ticket?

That's needed for sure. I was saying either we need to disable this using FF in PROD (unless we are ok with out of sync data)

Nov 12 '24 22:11 vysakh-menon-aot

I was saying either we need to disable this using FF in PROD (unless we are ok with out of sync data)

If we don't expect many (or any) business conversions from BEN to CC then we could do nothing ... but that's an @OlgaPotiagalova decision. What's the risk if this does happen?

How much effort is creating an equivalent filing type in COLIN?

Nov 12 '24 22:11 severinbeauvais

Impact: Will fail to sync the specific alteration and subsequent filings in that business.

Home team has to introduce this filing type and update all the relevant messaging (BN, MRAS, or any other). Once its in place we can update colin-api with the new filing type.

Nov 12 '24 22:11 vysakh-menon-aot