entity UI - Add Property Details (new fields, questions) to Review and Confirm, Application Details View and Registration Details View

4 fields

Oct 24 '24 16:10 mbertucci

@avni-work here is the ticket you asked fo r

Oct 25 '24 21:10 mbertucci

@kris-daxiom, let me know when it is okay to get started on this. thank you!

Oct 25 '24 21:10 avni-work

Issue with Ownership Type: Co-own:

https://strr-api-dev-i2rbretwta-nn.a.run.app/applications 400 error

Submitting this gives the following error:

{
    "details": [
        {
            "context": [],
            "json_path": "$.registration.unitDetails.ownershipType",
            "message": "'' is not one of ['OWN', 'RENT', 'CO_OWN']",
            "relative_path": [
                "registration",
                "unitDetails",
                "ownershipType"
            ]
        }
    ],
    "message": "Invalid request"
}

The Submitted json has an empty fields for ownersshipType:

{
    "primaryContact": {
        "name": {
            "firstName": "BCREGTEST Delbert",
            "lastName": "TWENTYFIVE"
        },
        "dateOfBirth": "1965-03-09",
        "details": {
            "preferredName": "",
            "phoneNumber": "6048313629",
            "extension": "",
            "faxNumber": "",
            "emailAddress": "[email protected]"
        },
        "mailingAddress": {
            "address": "1239 Hillgrove Road",
            "city": "North Saanich",
            "postalCode": "V8L 5K7",
            "province": "BC",
            "country": "CA"
        },
        "socialInsuranceNumber": "999 999 999",
        "businessNumber": "Stens Consulting Inc."
    },
    "unitAddress": {
        "address": "15-9762 Ermacora Rd",
        "addressLineTwo": "",
        "city": "Cranbrook",
        "postalCode": "V1C 7E1",
        "province": "BC",
        "country": "CA",
        "nickname": ""
    },
    "unitDetails": {
        "propertyType": "STRATA_HOTEL",
        "ownershipType": "",
        "rentalUnitSpaceType": "SHARED_ACCOMMODATION",
        "isUnitOnPrincipalResidenceProperty": false,
        "numberOfRoomsForRent": 20
    },
    "principalResidence": {
        "isPrincipalResidence": false,
        "agreedToRentalAct": false,
        "agreedToSubmit": true,
        "nonPrincipalOption": "Eligible strata hotel or motel",
        "specifiedServiceProvider": "n/a"
    },
    "registrationType": "HOST",
    "listingDetails": []
}

Oct 30 '24 18:10 rstens

Pass

Verified fix

Oct 30 '24 22:10 rstens

@fionazhou-jsb please test this one as well

Nov 01 '24 15:11 mbertucci

The labels and layout for the Property Details section are fixed in PR 270 UXA link: https://strr-ui-dev--pr-270-bbcap2d6.web.app/

Nov 05 '24 21:11 dimak1

@andyyanggov moved it to your column for UXA.

Nov 05 '24 22:11 fionazhou-jsb

✅ Labels fixed on the review page ❌ Labels not fixed on detail pages

Nov 06 '24 00:11 andyyanggov

I will update the Details pages as well. Thanks @andyyanggov

Nov 06 '24 00:11 dimak1

Ready for UXA: https://strr-ui-dev--pr-270-bbcap2d6.web.app/ @andyyanggov

Nov 06 '24 20:11 dimak1

✅ Labels fixed on the review page ✅ Labels fixed on detail pages

Nov 06 '24 21:11 andyyanggov

Little bit confused on what needs testing here. I'll just move it forward to Done and Andy has done the UI validation.

Nov 07 '24 19:11 rstens

@rstens this was to update the labels and layout for Property Details section on Review/App/Reg Details pages.

Nov 07 '24 20:11 dimak1

Tested in Dev. Reviewed the label and options on review page, application details and registration details page (from both examiner and host view) and they all work. cc @mbertucci

Nov 12 '24 02:11 fionazhou-jsb