entity icon indicating copy to clipboard operation
entity copied to clipboard

BUG: UI - PID is not showing on Review and Details page

Open dimak1 opened this issue 1 year ago • 3 comments

PID entered in Step 2 of the Rental Application is not showing up on the Review Page and Application Details for Host and Examiner page.

Screenshot 2024-10-18 at 08.00.05.png

Review and Confirm

Screenshot 2024-10-18 at 07.40.51.png

dimak1 avatar Oct 18 '24 14:10 dimak1

I do not think this was done?

rstens avatar Nov 01 '24 00:11 rstens

was done in https://github.com/bcgov/STRR/pull/253

avni-work avatar Nov 01 '24 02:11 avni-work

FAIL

Not showing PID on Application-details page. The data is there:

{
    "header": {
        "applicationDateTime": "2024-11-02T00:05:19.189058+00:00",
        "applicationNumber": "21925762862430",
        "decisionDate": null,
        "examinerActions": [],
        "examinerStatus": "Paid",
        "hostActions": [],
        "hostStatus": "Pending Approval",
        "isCertificateIssued": false,
        "name": "registration",
        "paymentAccount": "1699",
        "paymentStatus": "COMPLETED",
        "paymentToken": 42184,
        "reviewer": {},
        "status": "PAID",
        "submitter": {
            "displayName": "BCREGTEST Delbert TWENTYFIVE",
            "username": "bcsc/malpaovmqyxtxfdu47z54mwswuerbdni"
        }
    },
    "registration": {
        "listingDetails": [
            {
                "url": "https://www.airbnb.ca/your_listing123"
            }
        ],
        "primaryContact": {
            "businessNumber": "",
            "dateOfBirth": "1965-02-19",
            "details": {
                "emailAddress": "[email protected]",
                "extension": "",
                "faxNumber": "",
                "phoneNumber": "6048313629",
                "preferredName": ""
            },
            "mailingAddress": {
                "address": "1239 Hillgrove Road",
                "city": "North Saanich",
                "country": "CA",
                "postalCode": "V8L 5K7",
                "province": "BC"
            },
            "name": {
                "firstName": "BCREGTEST Delbert",
                "lastName": "TWENTYFIVE"
            },
            "socialInsuranceNumber": "999 999 999"
        },
        "principalResidence": {
            "agreedToRentalAct": false,
            "agreedToSubmit": true,
            "isPrincipalResidence": false,
            "nonPrincipalOption": "Located in exempt community",
            "specifiedServiceProvider": "n/a"
        },
        "registrationType": "HOST",
        "unitAddress": {
            "address": "15-3511 Granville Ave",
            "addressLineTwo": "",
            "city": "Richmond",
            "country": "CA",
            "nickname": "PID Test",
            "postalCode": "V7C 1C8",
            "province": "BC"
        },
        "unitDetails": {
            "businessLicense": "BC123456",
            "businessLicenseExpiryDate": "2025-10-31",
            "hostResidence": "ANOTHER_UNIT",
            "isUnitOnPrincipalResidenceProperty": true,
            "numberOfRoomsForRent": 4,
            "ownershipType": "OWN",
            "parcelIdentifier": "999-999-999",
            "propertyType": "SECONDARY_SUITE",
            "rentalUnitSpaceType": "ENTIRE_HOME"
        }
    }
}

"parcelIdentifier": "999-999-999",

But page is not showing, see https://strr-ui-dev.web.app/application-details/21925762862430 screencapture-strr-ui-dev-web-app-application-details-21925762862430-2024-11-01-17_11_07.png

Cannot test registration details because of wrong PID (Known issue with auto-approve).

Also I did not see the PID in the review page when submitting the applications.

rstens avatar Nov 02 '24 00:11 rstens

Could not show the previous instance anymore.

But on registration-details PID (https://strr-ui-dev.web.app/registration-details/152) is not Showing (+ some other display issues) screencapture-strr-ui-dev-web-app-registration-details-152-2024-11-04-09_59_21 (1).png

Result of application: https://strr-ui-dev.web.app/application-details/42947718252008 (Entered as BCREG0026)

rstens avatar Nov 04 '24 18:11 rstens

this seems like the old code.

avni-work avatar Nov 04 '24 18:11 avni-work

when i log into that account and look at this application i see: image.png

avni-work avatar Nov 04 '24 18:11 avni-work

Now showing up in temp url: image.png

rstens avatar Nov 04 '24 19:11 rstens

Looks like it is there. Is it in the right Location @andyyanggov ? https://strr-ui-dev.web.app/application-details/42947718252008 image.png

https://strr-ui-dev.web.app/registration-details/152 image.png

rstens avatar Nov 07 '24 00:11 rstens

Looks right to me.

andyyanggov avatar Nov 07 '24 01:11 andyyanggov

tested in Dev and it works. @mbertucci

fionazhou-jsb avatar Nov 07 '24 06:11 fionazhou-jsb