bcgov
UI - Determine Property Type
@avni-work it is assigned to you. Is it under dev? Should it be In Progress?
Reviewed and entered data into the new fields. Validated that this info is written to the database. Still missing the entered info in the application-details page but there is a separate ticket for that.
Issues:
- Address of rental unit address is not mandatory, it should be
- Number of Rooms for Rent does not seem to have an upper limit
Found a combo that has some errors. API is expecting the value that is not there. @avni-work
@rstens the order of these questions being asked is not right. I am moving this ticket to in progress. Please refer to design for the correct order. @dimak1 cc @mbertucci
Reminder to pass UI tickets through UXA, thanks 🙏
A couple of additional observations for the future (no need to fix them now—they'll do for the MVP):
- The new questions were designed to be radio buttons instead of dropdowns.
- The 'Number of Rooms for Rent' field doesn't match the design. It should allow users to type in the number as well.
@rstens found 2 issues cc @mbertucci @andyyanggov
- the wording for picklist for Q "where does the property host live on the property" is incorrect. It is not the same when choosing entire home or shared accommodation.
Design:
- Number of rooms for rent - now we allow users to enter numbers so it takes decimal values (i.e., 3.4).
@dimak1 When the user selects shared accommodation the drop down is just supposed to say
The host lives in this unit or The host lives another unit on the same property
Fixed dynamic dropdown and Review page. PR under review.
Confirmed to work as discussed (i.e., dynamic in the dropdown but static/generic on the review page)
@andyyanggov Thanks Andy, but it is not ready for QA yet. Needs a code review.
In the following scenario the review and confirm step does not correctly reflect the choices:
-
Start with: Selecting Rental Unit Details - Shared Accommodation...
-
Select: Host lives in this unit
-
Jump to Review and confirm
-
All good
-
Now to back to property details and select the following: Entire Home, Host field will change
-
Click on next
-
Go to Review and confirm
-
It does not reflect the choices made (did not receive the update)
-
Even if you force the selecttion, the review page will not update.
Confirmed to work as discussed (i.e., dynamic in the dropdown but static/generic on the review page)
@rstens This was a decision made a couple of days ago as a compromise for the MVP.
Basically, the Review page will show a static, simplified value (i.e., "The host lives in this unit"), but on the input side, it'll be dynamic based on whether 'Entire home' or 'Shared accommodation' is selected. If it's 'Entire home', we'll show that clarifying second part of the sentence to give the user a bit more context (i.e., "The host lives in this unit when it's not being rented")
This way, there's no additional backend work. Cc. @dimak1
@rstens @andyyanggov
Andy is correct. This is just the presentation text, the backend will capture the values correctly, either SAME_UNIT or ANOTHER_UNIT. We have two props for three text values so we have same text for the Same Unit option.
So this is a correct behaviour and not a bug.
The wording for the second question does not match the design. Leave it to @mbertucci to see if you want to close this ticket and its story level ticket. I can add the language update in #24950.
I am going to close this ticket and move the wording update to #23950 cc @mbertucci