entity icon indicating copy to clipboard operation
entity copied to clipboard
verified publisher icon bcgov

Name Request unable to create Name Change for Continued In company

Open Mihai-QuickSilverDev opened this issue 1 year ago • 22 comments

See also #23380.

Steps to reproduce the issue:

  • [ ] Launch Name Request
  • [ ] Select a name change for an existing company
  • [ ] When you search for the company type Cxxxxxxx
  • [ ] Try to complete the NR
  • [ ] You will get this error below
image.png

Mihai-QuickSilverDev avatar Sep 18 '24 17:09 Mihai-QuickSilverDev

  • [ ] Turns out this is extra urgent - Ops ticket just popped-up: https://sbc-registries.atlassian.net/browse/ITOPS-141678 @ozamani9gh @fodiley

Mihai-QuickSilverDev avatar Sep 18 '24 20:09 Mihai-QuickSilverDev

We’ve had another look and, as far as the legacy NAMES database is concerned, there is only one type of Restoration NR for BC companies, as below: image.png

Therefore, COLIN is still expecting a BC Company – Restore NR (REQUEST_TYPE_CD=RCR) whether the filing is a Limited Restoration Application, a Full Restoration Application, or a Convert Limited to Full Restoration Application.

As a result, I’m afraid that I have to advise you that I believe Name Request needs a change: further to your last screenshot, when Name Request is searching for valid companies, it needs to include companies in Limited Restoration for the purpose of being able to change a company’s name in a Convert Limited to Full Restoration.

Darci also just did some extra research and found an NR that was consumed for this purpose in January, as below:

Mihai-QuickSilverDev avatar Sep 20 '24 17:09 Mihai-QuickSilverDev

Test in DEV: input the corp_num='C0181655'. I got the following error in namex-api log:

2024-10-11 15:33:37,939 - namex - ERROR in api_resource:api_resource.py:14 - handle_exception: Error: MapRequestAttributesError("Error setting request attributes.\r\n\r\n'NoneType' object is not subscriptable")

The error caused by failure to find a request type by the input entity_type='C' (continued in) and request_action='CHG'. For example, entity_type='CR', request_action='NEW', the request_type_cd = 'CR'.

eve-git avatar Oct 11 '24 15:10 eve-git

The following corp_types are continue in corp types in legacy system: image.png

Here are the request type cd corresponding to continue-in in legacy system: image.png

based on the info above, I added a new request_type_mapping row as heightlighted below (the column are request_type_cd, corp_type, request_action): image.png

The above code change is for BC company continue-in. @Mihai-QuickSilverDev please let me know if we support other types of continue in

eve-git avatar Oct 11 '24 17:10 eve-git

@eve-git We support 4 types of Continued In companies:

  • [x] C - Continued In BC Ltd
  • [x] CCC - Continued In Community Contribution Company
  • [x] CUL - Continued In Unlimited Liability Company
  • [x] CBEN - Continued In Benefit Company @severinbeauvais could help with a mapping of company types used inside Name Request UI vs. company types used outside Name Request UI

Mihai-QuickSilverDev avatar Oct 16 '24 04:10 Mihai-QuickSilverDev

I added the following entries to namex based on the request type in legacy namex:

REQUEST_TYPE     ENTIRY_TYPE_CD     REQUEST_ACTION
CT                     C                    CHG
CCCT                  CCC                   CHG
ULCT                  CUL                   CHG
BECT                  CBEN                  CHG

eve-git avatar Oct 16 '24 17:10 eve-git

@Mihai-QuickSilverDev , I think that changing Namerequest UI to search for historical and limited-resto businesses should be a separate ticket, since that code is in a different repo (and hence, can be reviewed and deployed separately). But we need to think about this a bit. Currently, the business search for a restoration NR looks for historical businesses only. This is why limited-resto businesses are not found -- they are actually active. Should we open up this search to find historical and active businesses? Or should we look at a different design for searching limited-resto businesses?

severinbeauvais avatar Oct 29 '24 17:10 severinbeauvais

@Mihai-QuickSilverDev What alterations (CNV) are allowed for C, CBEN, CCC and CUL?

severinbeauvais avatar Oct 29 '24 17:10 severinbeauvais

  • [ ] Everything applicable to a BC Ltd. company is applicable to a Continued In company, according to their genom. So C follows BC Ltd., CUL follows ULC, CCC follows CC.

Mihai-QuickSilverDev avatar Oct 30 '24 16:10 Mihai-QuickSilverDev

@eve-git @Mihai-QuickSilverDev

Yes, 4 new entity types are needed. Please add these to the EntityTypes enum:

CONTINUE_IN = 'C'
BEN_CONTINUE_IN = 'CBEN'
CCC_CONTINUE_IN = 'CCC'
ULC_CONTINUE_IN = 'CUL'

Please add these descriptions:

EntityTypes.CONTINUE_IN = 'Corporation',
EntityTypes.BEN_CONTINUE_IN = 'Benefit Company',
EntityTypes.CCC_CONTINUE_IN = 'Community Contribution Company',
EntityTypes.ULC_CONTINUE_IN = 'Unlimited Liability Company',

Please look up the legacy codes and add these to "request_type_mapping". (Replace "xxx" with the appropriate legacy code.)

('CT', EntityTypes.CONTINUE_IN .value, RequestAction.CHG.value, True),
('CT', EntityTypes.CONTINUE_IN .value, RequestAction.RESUBMIT.value, True),
('xxx', EntityTypes.CONTINUE_IN .value, RequestAction.REST.value, True), // SB says: see also RCR
('xxx', EntityTypes.CONTINUE_IN .value, RequestAction.REH.value),
('xxx', EntityTypes.CONTINUE_IN .value, RequestAction.REN.value),
('xxx', EntityTypes.CONTINUE_IN .value, RequestAction.RESUBMIT.value),

('CCCT', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.CHG.value, True),
('CCCT', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.RESUBMIT.value),
('xxx', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.REST.value, True), // SB says: see also RCC
('xxx', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.REH.value),
('xxx', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.REN.value),
('xxx', EntityTypes.CCC_CONTINUE_IN .value, RequestAction.RESUBMIT.value),

('ULCT', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.CHG.value, True),
('ULCT', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.RESUBMIT.value),
('xxx', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.REST.value, True), // SB says: see also RUL
('xxx', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.REH.value),
('xxx', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.REN.value),
('xxx', EntityTypes.ULC_CONTINUE_IN .value, RequestAction.RESUBMIT.value),

('BECT', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.CHG.value, True),
('BECT', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.RESUBMIT.value),
('xxx', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.REST.value, True), // SB says: see also BERE
('xxx', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.REH.value),
('xxx', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.REN.value),
('xxx', EntityTypes.BEN_CONTINUE_IN .value, RequestAction.RESUBMIT.value),

Also, for above, there need to be entries for CNV (conversion/alteration). Again, please look up the legacy codes. The following conversions are valid:

  • C -> CBEN (see also BECV)
  • C -> CCC (see also CCV)
  • C -> CUL (see also UC)
  • CBEN -> C (see also BECR)
  • CUL -> C (see also ULCB)
  • CUL -> CBEN (see also ULBE)

Please update "raw_nr_to_action_mapping" as well.

severinbeauvais avatar Oct 30 '24 19:10 severinbeauvais

@severinbeauvais I am not clear what to update for Conversion and raw_nr_to_aciton_mapping. Please advise. Thanks

eve-git avatar Oct 30 '24 22:10 eve-git

Eve, I was hoping you understood the raw_nr_to_action_mapping structure better than me 😆

I think you can probably clone some of the existing 'BC', 'BEN', 'CC' and 'ULC' lines and swap in 'C', 'CBEN', 'CCC' and 'CUL'. Specifically, the codes for:

  • CHG
  • RESUMBIT
  • REST
  • REH
  • REN

severinbeauvais avatar Oct 30 '24 22:10 severinbeauvais

PS I'd like to see what new request codes you found on the legacy system for continued in businesses -- please add me to your PR. Thanks!

severinbeauvais avatar Oct 30 '24 22:10 severinbeauvais

Eve, do you know if this needs to be updated with the new business types? https://github.com/bcgov/namex/blob/3d943dfa9197ea879bed6157a6ed5d98dc127630/api/namex/models/request.py#L369

severinbeauvais avatar Oct 30 '24 22:10 severinbeauvais

I think raw_nr_to_action_mapping and the alteration mappings are all good.

eve-git avatar Oct 31 '24 15:10 eve-git

@severinbeauvais Request Action mapping in namerequest has MVE for continue-in. So, is it the type in request type mapping in api for continue in? https://github.com/bcgov/namerequest/blob/main/app/src/list-data/request-action-mapping.ts#L62

eve-git avatar Oct 31 '24 16:10 eve-git

@severinbeauvais Let's just focus Name Change on this ticket. Thanks

eve-git avatar Oct 31 '24 16:10 eve-git

The comments in the Namerequest code indicate that MVE uses regular business types but will become continued-in business types.

In Namex code, the request_type_mapping structure has codes for the 6 entity types listed in Namerequest code (4 corps + CP + SO). I think this is OK.

In Namex code, the raw_nr_to_action_mapping structure also has codes matching the other structure (CT, CCCT, ULCT, BECT).

I think this is all OK. As far as I know, MVE (continuation in) NRs are currently working correctly. (It's currently possible to create a NR to continue in a foreign or expro business.)

severinbeauvais avatar Oct 31 '24 16:10 severinbeauvais

@severinbeauvais Let's just focus Name Change on this ticket. Thanks

So you want another ticket for restoration NRs?

severinbeauvais avatar Oct 31 '24 16:10 severinbeauvais

I've added mappings for continue-in and restoration REH to the code. I did not include others because I couldn't find corresponding continue-in mappings in the RequestActionMappingI within namerequest.

eve-git avatar Oct 31 '24 18:10 eve-git

I've added mappings for continue-in and restoration REH to the code. I did not include others because I couldn't find corresponding continue-in mappings in the RequestActionMappingI within namerequest.

In Namerequest UI, the CNV (conversion/alteration) mappings are done in a separate file -- see https://github.com/bcgov/namerequest/blob/main/app/src/list-data/conversion-types.ts.

severinbeauvais avatar Oct 31 '24 18:10 severinbeauvais

When you update your PR, I will have a look at the changes and will add further comments if needed.

severinbeauvais avatar Nov 01 '24 23:11 severinbeauvais

* * UPDATE * *

Per discussion with Eve, this ticket will focus only on Name Change NRs for the new company types.

  • [ ] The following EntityTypes need to be added:
CONTINUE_IN = 'C'          # Continued In BC Limited
CONTINUE_IN_BEN = 'CBEN'   # Continued In Benefit Company
CONTINUE_IN_CCC = 'CCC'    # Continued In Community Contribution Company
CONTINUE_IN_ULC = 'CUL'    # Continued In Unlimited Liability Company
  • [x] The following EntityTypeDescriptions need to be added:
EntityTypes.CONTINUE_IN: 'Corporation',
EntityTypes.CONTINUE_IN_BEN: 'Benefit Company',
EntityTypes.CONTINUE_IN_CCC: 'Community Contribution Company',
EntityTypes.CONTINUE_IN_CUL: 'Unlimited Liability Company',
  • [x] The following request_type_mapping need to be added:
('CCR', EntityTypes.CONTINUE_IN.value, RequestAction.CHG.value, True),
('CCR', EntityTypes.CONTINUE_IN.value, RequestAction.RESUBMIT.value),
('BEC', EntityTypes.CONTINUE_IN_BEN.value, RequestAction.CHG.value, True),
('BEC', EntityTypes.CONTINUE_IN_BEN.value, RequestAction.RESUBMIT.value),
('CCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.CHG.value, True),
('CCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.RESUBMIT.value),
('CUL', EntityTypes.CONTINUE_IN_ULC.value, RequestAction.CHG.value, True),
('CUL', EntityTypes.CONTINUE_IN_ULC.value, RequestAction.RESUBMIT.value, True),
  • [x] Please add this missing entry in request_type_mapping:
('CUL', EntityTypes.UNLIMITED_LIABILITY_COMPANY.value, RequestAction.RESUBMIT.value, True),
  • [ ] The following raw_nr_to_action_mapping need to be added:
('CCR', 'C', 'Continued In BC Limited Company', 'Change of Name', 'lear', None, None, None),
('CCC', 'CCC', 'Continued In CCC', 'Change of Name', 'lear', None, None, None),
('CUL', 'CUL', 'Continued In ULC', 'Change of Name', 'lear', None, None, None),
('BEC', 'CBEN', 'Continued In Benefit Company', 'Change of Name', 'lear', 'alteration', None, "{'filing': {'header': {'name': {entitiesFilingName} }, '{entitiesFilingName}': {'nameRequest': {'nrNumber': '{nrNumber}', 'legalName': '{legalName}', 'legalType': '{legalType}'}}}}"),

The BEC/CBEN entry above looks weird but it's consistent with the BEC/BEN entry so I assume it will work.

severinbeauvais avatar Nov 05 '24 18:11 severinbeauvais

  • [x] If this ticket will also add the restoration codes then please add the following to request_type_mapping:
    ('RCR', EntityTypes.CONTINUE_IN.value, RequestAction.REST.value, True),
    ('RCR', EntityTypes.CONTINUE_IN.value, RequestAction.REH.value),
    ('RCR', EntityTypes.CONTINUE_IN.value, RequestAction.REN.value),
    ('RCR', EntityTypes.CONTINUE_IN.value, RequestAction.RESUBMIT.value),

    ('RCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.REST.value, True),
    ('RCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.REH.value),
    ('RCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.REN.value),
    ('RCC', EntityTypes.CONTINUE_IN_CCC.value, RequestAction.RESUBMIT.value),

    ('RUL', EntityTypes.CONTINUE_IN_CUL.value, RequestAction.REST.value, True),
    ('RUL', EntityTypes.CONTINUE_IN_CUL.value, RequestAction.REH.value),
    ('RUL', EntityTypes.CONTINUE_IN_CUL.value, RequestAction.REN.value),
    ('RUL', EntityTypes.CONTINUE_IN_CUL.value, RequestAction.RESUBMIT.value),

    ('BERE', EntityTypes.CONTINUE_IN_CBEN.value, RequestAction.REST.value, True),
    ('BERE', EntityTypes.CONTINUE_IN_CBEN.value, RequestAction.REH.value),
    ('BERE', EntityTypes.CONTINUE_IN_CBEN.value, RequestAction.REN.value),
    ('BERE', EntityTypes.CONTINUE_IN_CBEN.value, RequestAction.RESUBMIT.value),
  • [x] Also, please add the following to raw_nr_to_action_mapping:
('RCR', 'C', 'Continued In BC Company', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None),
('RCC', 'CCC', 'Continued In CCC', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None),
('RUL', 'CUL', 'Continued In ULC', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None),
('BERE', 'CBEN', 'Continued in Benefit Company', 'Restoration', 'lear', None, None, None),

severinbeauvais avatar Nov 05 '24 22:11 severinbeauvais

moved this comment to bottom

severinbeauvais avatar Nov 05 '24 23:11 severinbeauvais

@eve-git What's your plan to test these changes? I have provided details above but Namerequest UI need to talk to an instance of Namex API that contains your changes. Do you want to just deploy Namex API to Dev (after fixing the last 2 comments in the PR)?

severinbeauvais avatar Nov 06 '24 19:11 severinbeauvais

The namex-api will be deployed alongside the NRO decommission. We plan to begin testing the namex-api starting tomorrow.

eve-git avatar Nov 06 '24 19:11 eve-git

The namex-api will be deployed alongside the NRO decommission. We plan to begin testing the namex-api starting tomorrow.

Sounds good. But there's another (high priority) Namex API ticket: #24193. Do you want to wait for this one and test everything together?

severinbeauvais avatar Nov 06 '24 19:11 severinbeauvais

I'm not sure; Omid handles the releases and deployments

eve-git avatar Nov 06 '24 21:11 eve-git

@ozamani9gh I hear that your team will deploy Namex API tomorrow and begin some testing...

There's another high priority Namex API ticket (#24193). (It's an easy one.) Do you want to implement it asap so it can be deployed and tested tomorrow (or soon after)? Or, are you planning another round of deployment and testing soon (before Directed Launch) that it would fall under?

severinbeauvais avatar Nov 06 '24 22:11 severinbeauvais