entity icon indicating copy to clipboard operation
entity copied to clipboard

API - Correct Statuses throughout application

Open mbertucci opened this issue 1 year ago • 1 comments

https://bcgov.sharepoint.com/:x:/r/teams/09399/Shared%20Documents/Product-Scrum%20Team%20Chat/Field%20validation%20and%20Status%20Table.xlsx?d=wd73427566b6148b48776b7c8682de8e9&csf=1&web=1&e=djD5qC&nav=MTVfezRGMDRERDMwLUFGRUQtNDE4Ri1CQUU3LTkxQjc0ODI2RTU4RH0

mbertucci avatar Aug 22 '24 20:08 mbertucci

we need to have versioning on the excel table so we we now what has changed since the last time we reviewed it.

mbertucci avatar Aug 22 '24 20:08 mbertucci

We two API tickets related to updating statuses #22831 - API - update actions in application · bcgov/entity (zenhub.com) #22396 API - Correct Statuses throughout application · bcgov/entity (zenhub.com)

and one UI ticket #22397

mbertucci avatar Sep 09 '24 23:09 mbertucci

@rstens because we didn't want to break the app, this was not merged to main, but rather into a separate branch. So this is not deployed to Dev env. I will continue to work on UI changes (on this separate branch) and then merge to main and promote to Dev.

Is this ok with you, can we proceed without testing this specific ticket yet?

dimak1 avatar Sep 16 '24 16:09 dimak1

Waiting for the UI ticket

jdyck-fw avatar Sep 19 '24 15:09 jdyck-fw

22832 will be merged with this as one

qudsia-khan-fw avatar Sep 27 '24 15:09 qudsia-khan-fw

API changes are deployed to DEV. Postman tests can be used to QA this if needed or it can be QA'd once UI changes are available.

kris-daxiom avatar Oct 03 '24 18:10 kris-daxiom

I'll revisit once the UI is there. I reviewed the code and that looks straightforward. No other observation (for now).

rstens avatar Oct 04 '24 17:10 rstens

Mind you , the UI might seem broken (because it is not aligned with te new changes) and you'll see statuses like this:

Application Status

Status

applicationDetails.FULL_REVIEW_APPROVED

rstens avatar Oct 04 '24 18:10 rstens

@rstens I'm working on updating UI with the new statuses.

dimak1 avatar Oct 04 '24 18:10 dimak1

@dimak1 https://github.com/bcgov/STRR/pull/160 will include the UI changes for this.

shaangill025 avatar Oct 04 '24 18:10 shaangill025

@dimak1 , @shaangill025 All good

rstens avatar Oct 04 '24 18:10 rstens

@roland we promoted all changes just before this PR to test. So everythingelse before this should be there in test

kris-daxiom avatar Oct 04 '24 18:10 kris-daxiom