entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - Add Loading State

Open dimak1 opened this issue 1 year ago • 3 comments

  • No Loading Panel/spinner when the UI loads for the first time.
  • No indication of work being done;
  • the application "freezes" and gives no indication of ongoing processes.

UX/UI Link: https://www.figma.com/design/R9GF5wvwq2TrnbnsbhPfvV/STR-Application-Tickets?node-id=6681-14210

dimak1 avatar Jul 26 '24 20:07 dimak1

Need a design for a loading indicator

mbertucci avatar Aug 07 '24 18:08 mbertucci

Throughout the application.
Alexis to provide a few loading states.

  1. When application is loading
  2. Trying to make a payment and waiting to go to next page - the payment screen and then after the payment is successful.
  3. Any submission of data

mbertucci avatar Aug 07 '24 18:08 mbertucci

@mbertucci is ok with the design Alexis proposed. @andybcgov if you are ok with it, can you move it to design complete? Thx

fionazhou-jsb avatar Sep 06 '24 17:09 fionazhou-jsb

Ready for UXA: https://strr-ui-dev--pr-170-sefmeju5.web.app/ @andyyanggov

dimak1 avatar Oct 09 '24 19:10 dimak1

The loading modal shifts slightly in position as the page loads, which I find a little jarring. Also, I'm not sure if the forced redirect from the dashboard is intentional (for testing purposes?) or a bug. It's happening in DEV, too.

andyyanggov avatar Oct 09 '24 20:10 andyyanggov

Thanks for review @andyyanggov

  1. Shift to the left is due to the scroll bar, which appears and shifts the content to the left. I can try to reduce/remove the animation once the page is loaded, so the loading modal will almost instantly disappear (if that makes it look better).
  2. For the redirect, if there are no applications/registrations in the Dashboard, it redirects to the rental registration page. It could change if you want.

dimak1 avatar Oct 09 '24 20:10 dimak1

Thanks for the explanations @dimak1

  1. We can try it, but it's not a big deal if it's a lot of work to fix.
  2. I thought we have an empty state for the dashboard. The forced redirection feels to me like an unexpected behaviour. Sorry, it's not part of the scope of this ticket, we can chat about it offline.

andyyanggov avatar Oct 10 '24 15:10 andyyanggov

Tested again. Loading modal no longer shifts to the left. LGTM.

andyyanggov avatar Oct 11 '24 15:10 andyyanggov

@rstens PR is merged and should soon be available in Dev. Thanks!

dimak1 avatar Oct 11 '24 16:10 dimak1

Passed

Tested:

Using: https://www.debugbear.com/blog/chrome-devtools-network-throttling to slow down the browser network and therefore make the loading state more visible. Thanks Dima for tip!

  • [x] When application is loading
  • [x] Trying to make a payment and waiting to go to next page - the payment screen and then after the payment is successful.
  • [x] Any submission of data

Even with the slower network, it is hard to see, but the "Loading.." pages are there.

rstens avatar Oct 15 '24 16:10 rstens