entity icon indicating copy to clipboard operation
entity copied to clipboard
verified publisher icon bcgov

The Alternate Names block does not display the Firm information when a company of legal type 'C' is used as the Proprietor for the Firm.

Open riyazuddinsyed opened this issue 1 year ago • 2 comments

Describe the bug in the current situation When the user adds a 'C' type company as a proprietor for a firm, the firm information does not appear in the Alternate Names block. This issue does not occur with other legal types, such as 'BEN'.

Steps to reproduce the behavior:

  1. Hit on GET 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1082498'
  2. Observe that the has a Legal Name 'C' company as proprietor i,e 'C9900770'
  3. Now hit on GET 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/C9900770
  4. Now observe that the Alternate Name block section is empty.

Screenshots/ Visual Reference/ Source Screen Shot 2024-07-04 at 1.42.39 PM.png

Screen Shot 2024-07-04 at 1.48.21 PM.png

riyazuddinsyed avatar Jul 04 '24 20:07 riyazuddinsyed

@JazzarKarim Can you have a quick look at this, please? Is it a UI or API issue?

severinbeauvais avatar Jul 11 '24 17:07 severinbeauvais

@severinbeauvais Apologies Sev, I just got freed up. Will take a quick look now.

JazzarKarim avatar Jul 11 '24 20:07 JazzarKarim

@JazzarKarim, @vysakh-menon-aot should this be fixed before the MVP? What is the impact if it is not?

OlgaPotiagalova avatar Feb 04 '25 23:02 OlgaPotiagalova

@JazzarKarim, @vysakh-menon-aot should this be fixed before the MVP? What is the impact if it is not?

I'm not sure what the impact here is exactly. This is an old ticket.

@riyazuddinsyed Riyaz, do you know what the impact of this is exactly?

JazzarKarim avatar Feb 05 '25 00:02 JazzarKarim

Here are the finding based on the info from the document (Argus pointed me to the doc related to this change) Alternate names block is populated correctly if corp is added as a proprietor for SP. Alternate names block is empty when corp is added as a partner for GP. This is the expected behavior.

Tested in DEV with different corps and firms. Here are some examples: FM1119628 GP C9900879 C company this is added as partner FM1119631 GP BC0887594 BEN company this is added as partner

FM1120203 SP BC0887549 BEN company this is added as proprietor FM1120206 SP C9900879 C company this is added as proprietor

Tested in TEST with different corps and firms. Here are some examples: FM1142602 SP BC1198730 BEN company this is added as proprietor FM1142601 GP BC1198853 BEN company this is added as partner

@riyazuddinsyed

ketaki-deodhar avatar Feb 10 '25 22:02 ketaki-deodhar

Moving to Ready for QA for @riyazuddinsyed to retest

ketaki-deodhar avatar Feb 12 '25 15:02 ketaki-deodhar