entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - A11Y - Add landmarks

Open saragunnarsson opened this issue 1 year ago • 7 comments

Figma file here

  • [x] Add landmarks marked up in figma
  • [x] Add skip to main content link

saragunnarsson avatar Jun 13 '24 17:06 saragunnarsson

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett

saragunnarsson avatar Jun 13 '24 17:06 saragunnarsson

@LizGovier Would like to confirm page structure/landmarks.

There is another component that is not mentioned in the Figma - System Banner. Currently it's located in <main>. After we update the structure to move Breadcrumbs above the <main> into <nav>, the system banner would be between <header> and <nav>. Is that ok?

Screenshot 2024-07-09 at 08.49.51.png

dimak1 avatar Jul 09 '24 15:07 dimak1

Ready for UXA: https://bcregistry-assets-dev--pr-1973-8ya0d1kp.web.app/

dimak1 avatar Jul 09 '24 19:07 dimak1

Hey @dimak1 I'm just looking at the landmarks and there seems to be 2 navigation tags, The second one goes straight to the bottom. (Note: using SkipTo chrome extension) Screen Shot 2024-07-10 at 12.57.22 PM.png

cc @arlentees I wouldn't mind enhancing this landmark feature to show more landmark sections with section title. Will also reach out to Alexis regarding this. Example from W3.org: Screen Shot 2024-07-10 at 12.58.05 PM.png

LizGovier avatar Jul 10 '24 17:07 LizGovier

@LizGovier There are indeed two Navigation tags. Using WAVE extension I can see one for Top Nav, and the other is for Footer. Please let me know if you want to make any updates.

dimak1 avatar Jul 10 '24 17:07 dimak1

Thanks @dimak1 Using the 'WAVE' chrome extension, I verified the MHR/PPR Dashboard and an MHR Registration page. Both showed the proper landmarks that Sara provided. This is RFQA

Screen Shot 2024-07-11 at 11.53.12 AM.png Screen Shot 2024-07-11 at 11.55.25 AM.png

LizGovier avatar Jul 11 '24 16:07 LizGovier

Thanks @LizGovier! For RFQA, you can also assign it directly to Divya and put it in the RFQA column.

dimak1 avatar Jul 11 '24 16:07 dimak1

Had to sync with main and resolve some conflicts. Should be available in DEV now. Thanks!

dimak1 avatar Jul 15 '24 15:07 dimak1

Verified in TEST!

image.png image.png image.png

chdivyareddy avatar Jul 16 '24 23:07 chdivyareddy