entity icon indicating copy to clipboard operation
entity copied to clipboard
verified publisher icon bcgov

UI - A11Y - Add Accessible Semantics

Open arlentees opened this issue 1 year ago • 6 comments

Figma Link Here

  • [x] Missing headings (line 13, 51 and 71 from the spreadsheet)
  • [x] Fix accessible semantics on the dashboards

Accessibility report https://docs.google.com/spreadsheets/d/1OC89KbzUyIK7rUcQzzrE7X6ouZx_4F1s7FTtygayFUg/edit#gid=560981720

arlentees avatar May 15 '24 23:05 arlentees

on hold pending design

arlentees avatar May 21 '24 21:05 arlentees

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett

saragunnarsson avatar Jun 13 '24 18:06 saragunnarsson

Ready for UXA: https://bcregistry-assets-dev--pr-1970-vdfzyya8.web.app/

Pages that were worked in this ticket:

  • Dashboard
  • Mhr Information + Review
  • Mhr Transport Permit + Review
  • Fee Summary
  • Unit Notes Panels + Review
  • Tombstone

dimak1 avatar Jul 09 '24 22:07 dimak1

Thanks @Dima, Just a couple of items

PPR/MHR Dashboard

  • [x] Back button near breadcrumb Link.png
  • [x] Button Naming (Search) Could we name these two buttons: Search and Client Search Button Naming.png

LizGovier avatar Jul 11 '24 17:07 LizGovier

@dimak1 Still working on this ticket, I pressed 'enter' too soon. Also, should I assign this to Cameron?

LizGovier avatar Jul 11 '24 17:07 LizGovier

@LizGovier the things you mentioned above (button aria-label) were not in the scope of this ticket. We can fix them as part of this ticket by increasing the scope, but there are more buttons that need text, which could potentially be its own ticket. Let's see how much feedback there is, and we'll assign it accordingly. Thank you!

dimak1 avatar Jul 11 '24 19:07 dimak1

Hey @dimak1

Great work on this! Just a couple of things that I noticed in PPR Screen Shot 2024-07-16 at 12.11.24 PM.png

Screen Shot 2024-07-16 at 12.19.57 PM.png

LizGovier avatar Jul 16 '24 16:07 LizGovier

Thanks @LizGovier, I can fix these. Could you pls provide aria-label for those buttons from your comment earlier (missing name for Back button in breadcrumb).

dimak1 avatar Jul 16 '24 16:07 dimak1

Updated as per comments. Preview: https://bcregistry-assets-dev--pr-1970-vdfzyya8.web.app/

dimak1 avatar Jul 17 '24 12:07 dimak1

@dimak1 We'll leave the naming for the buttons at this moment as they need to be thought out more, especially with the dropdown button in search.

This is RFQA

@chdivyareddy I'm not sure how much accessibility testing you been doing, but I've been using the WAVE chrome extension to test: https://wave.webaim.org/extension/ For this ticket I would turn off 'Errors', 'Alerts', and 'Features' Screen Shot 2024-07-17 at 9.55.48 AM.png

Structure Tab shows the headings Screen Shot 2024-07-17 at 9.56.36 AM.png

Order shows the buttons/links Screen Shot 2024-07-17 at 9.57.10 AM.png

LizGovier avatar Jul 17 '24 14:07 LizGovier

@LizGovier , thanks for the input, I'm using WAVE tool as well for testing:)

chdivyareddy avatar Jul 17 '24 15:07 chdivyareddy

Ready in DEV.

dimak1 avatar Jul 19 '24 14:07 dimak1

Verified in DEV for the Dashboard, Mhr Information + Review screen, Mhr Transport Permit + Review screen, Unit Notes Panels + Review screen.

chdivyareddy avatar Jul 22 '24 22:07 chdivyareddy