bcgov
Legal API - Integrate disable NR check feature flag
We need a feature flag to be able to disable NR checks in the sandbox. Note that all non-sandbox environments will always have this flag turned off.
This feature flag will need to be integrated into the nr_validate function of the namex service in legal api.
TODOs
- [x] Update
nr_validatefunction in namex service in legal api to return valid NR result whendisable-nr-checkfeature flag is on. Essentially update this function - [x] Add/Update tests as appropriate
@vishnup0422 @riyazuddinsyed I fixed a bug I found when the disable-nr-check feature flag was turned on.
I verified that the IA filing is able to pass validation when disable-nr-check is on now using an already consumed NR.
Note that this fix is only in Dev right now. Let me know when you need to disable-nr-check feature flag turned on.
Here are the steps I used to test:
- Created a BEN(BC0878513, AC BEN 2024.MAY.9 21.59 TEST CORP.) with approved NR 4397108 in Dev.
- Tried submitting another IA filing with the same NR(NR 4397108) which was properly blocked by the POST /business endpoint. Note that the UI will not allow using the already consumed NR so tested directly via POST /business endpoint Http Request Http Response
- Turned
disable-nr-checkfeature flag on - Tried submitting another IA filing with the same NR(NR 4397108) via POST /business endpoint which passed validation as expected. Http Request Http Response
Performed 2 scenarios with the help of Argus Test env:
Scenario1: Using the Consumed NR for filing another Incorporation. Created a BEN with approved NR 2066581. Sent request to another IA filing with the same NR(NR 2066581) which was properly blocked by the POST /business endpoint.
Turned disable-nr-check feature flag on
Tried submitting another IA filing with the same NR(NR 2066581) via POST /business endpoint which passed validation as expected.
Scenario2: Filing for an Incorp with the consumed Name Change Request.
