entity icon indicating copy to clipboard operation
entity copied to clipboard

Create UI: implement "Existing Business Information" component (step 1) - PART 3

Open severinbeauvais opened this issue 1 year ago • 2 comments

This is work continued from #20889 (that exceeded the scope of that ticket, or had outstanding dependencies).

  • [x] remove Authority Name
  • [x] remove authorization confirmation checkbox
  • [ ] ~remove Type of Business radio buttons and update conditional upload and validation~ - UNDER DISCUSSION
  • [x] update review page per latest designs
  • [ ] ~hide Identifying Number on review page if user chose expro lookup path~ obsolete
  • [ ] ~add enum for LOOKUP/MANUAL~ not needed, used 'LOOKUP' | 'MANUAL' instead
  • [x] change Your Business in Home Jurisdiction icons to ~home_work~ home0city-outline (step 1 and review page)
  • [ ] finish affidavit upload
  • [ ] fetch xpro business data from COLIN (may need new COLIN_API environment key)
  • [ ] verify Court Order / POA is on Review page and working for all entity types (staff only), same as IA
  • [ ] update filing save + resume
  • [ ] update/add unit tests for new code
  • [ ] verify #21308 and close it if it is resolved

severinbeauvais avatar May 03 '24 18:05 severinbeauvais

Blocked while a waiting final requirements from the business:

  • should we pre-populate some fields (from COLIN data), and which ones?
  • which fields should be editable or readonly?

Also, @yuisotozaki, please update designs if needed to account for entity type radio boxes + confirmation checkbox?

severinbeauvais avatar May 16 '24 17:05 severinbeauvais

From Elizabeth Espinosa:

  1. Extrapro name pulled from Colin corresponding to the A# is NOT editable.
  2. Other information pulled from Colin related to the A# should be displayed AND be editable.

severinbeauvais avatar May 16 '24 17:05 severinbeauvais

To do: add hints to dates as below.

image.png

severinbeauvais avatar May 23 '24 17:05 severinbeauvais

Test Notes

All the functionality (including tooltips, validation and save/resume) is complete for the business search component:

image.png

Most of the functionality (including tooltips, validation and save/resume) is complete for the manual entry component (missing: affidavit upload):

image.png

Most of the functionality (including tooltips, validation and save/resume) is complete for the continuation authorization component (missing: updated file upload design):

image.png

All the functionality is complete for the review and confirm page.

Also affected by this feature is the date picker for:

  1. Start Date (firm registration)
  2. Resolution Date (coop dissolution)
  3. Dissolution Date (firm dissolution)

I have verified all the above.

severinbeauvais avatar May 27 '24 18:05 severinbeauvais

@severinbeauvais

Wether we need to create to fix this entry and output as shown below. If already , ticket is available , please ignore this The below fields are not saved. Home Jurisdiction Authorization Date Expiry date Input Entry image.png

Review and Confirm page

image.png

NaveenHebbale avatar May 27 '24 20:05 NaveenHebbale

Naveen, where are you testing this? I just tried in Dev and, upon successful business search, the fields are all saved to the draft, and I can resume them later.

Sample ULC continuation in: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TyS39DGw5j&accountid=3040

Sample CBEN continuation in: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TbY9bJGz0k&accountid=3040

severinbeauvais avatar May 27 '24 20:05 severinbeauvais

@severinbeauvais: Sorry there was some error loading dev It is working - Only - Registration Number in Home Jurisdiction, this field is not available for the input page

https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TcAD4Re5m9&accountid=668

image.png

NaveenHebbale avatar May 27 '24 20:05 NaveenHebbale

The UI design does not show a prompt for Registration Number in Home Jurisdiction when the business is an expro. That information is supposed to come from COLIN. However, you are testing in Dev environment and it seems that COLIN data there is incomplete.

severinbeauvais avatar May 27 '24 20:05 severinbeauvais

Ready for QA.

yuisotozaki avatar May 27 '24 22:05 yuisotozaki

Test scenario:

  • Extrapro Historical - Looks good
  • Extrapro Active - Looks good
  • Extrapro ULC - Looks good
  • Manual Entry - Looks good

ketaki-deodhar avatar May 28 '24 19:05 ketaki-deodhar

Closed

NaveenHebbale avatar May 28 '24 20:05 NaveenHebbale