bcgov
Remove -Refresh F5 - Output Page - Hide Documents
The button needs to exist because this ledger entry is an expanded list item (which needs to be expanded or contracted).
How about this?
The code change (line 15):
Sample filing: http://localhost:8080/Ta08xzwyRK?filing_id=149112
Design team met on May 9 to review this design.
- Remove/hide the "Hide Documents" button altogether in this state
- The design team is curious to learn why we cannot simply wait longer after filing submission for the real URL and load that. Or, add a timer that waits for the backend process to complete and then redirect to the real URL.
OK, we can implement a special case to remove the expansion toggle button altogether. We should also implement a special case that this type of filing is always auto-expanded (since, without the button, it cannot be expanded if collapsed).
As for why not wait longer? Mostly it's because the back end processes can sometimes get stuck (until we restart them). There is no "minimum wait time for BE to complete" value.
The design team's dream solution is to have the front time-out on the back end and have a purpose designed page to let the user know that a) the filing was submitted, b) something went wrong so we cannot display the result, and c) please check back later.
That's doable. What do you think the business page should look like during the delay period? How long should the timeout be? Is a modal OK to inform the user? What are the modal actions?
@ArwenQin @OlgaPotiagalova
I pre-assigned this ticket to Arwen.
Arwen, when you are finished your previous ticket (or if you are temporarily blocked on it and need more work), then move this ticket to In Progress.
Arwen, you and I need to chat about the requirements and how to satisfy them. It will be a bit exploratory to figure out the cleanest way to implement this but I will work through it with you.
Oops! I just noticed that there's a second "Hide Details" button on the ledger item. This ticket should go back to the Sprint Backlog or In Progress.
^^ I believe the button above is in FiledAndPendingPaid.vue.
I also think that FutureEffectivePaid needs to be updated similarly.
@ketaki-deodhar , see what was done for PR 656, linked above, in case you want to copy that change.
Observation:
- I can tab into the div and press space to trigger the expand / collapse; the div should not be a tab target
@ketaki-deodhar @ArwenQin , we have CSS to disable pointer events. Please also add tabindex="-1" to the div to prevent tabbing onto it. (See this commit for sample code.)
Yui's second observation (exposing the hidden buttons) means we're not looking at the right HTML elements to determine if the div is open or closed. Or something. But if we block the tabbing then this won't come into play, so I say we ignore it.
Pay system still not working - cannot UXA the main part of this ticket.
The main part of this ticket passes UXA. Just need the tab-focus removed from the div and we're good to go!