entity icon indicating copy to clipboard operation
entity copied to clipboard

Create UI: email and phone number is being displayed as Not Found

Open riyazuddinsyed opened this issue 1 year ago • 1 comments

Describe the bug in the current situation When the user files Continuation In Filing from an NR that is affiliated to the account then the Email and Phone number are displayed as Not Found even though the profile section has both email and phone number.

Steps to reproduce the behavior:

  1. Go to 'https://dev.bcregistry.gov.bc.ca/?accountid=2079'
  2. Login as BCREGA001/98900001
  3. Search for PS5 ULC Continuation In NR
  4. Start a Continuation In filing
  5. On the Create UI observe that the Email and Phone number section says not found.

Screenshots/ Visual Reference/ Source Screen Shot 2024-05-02 at 12.30.44 PM.png

riyazuddinsyed avatar May 02 '24 19:05 riyazuddinsyed

~Go to step 2 and enter the Registered Office Contact Information. Now does the Email and Phone display?~

~This is the same in an IA or Registration filing.~

~Please close this ticket if my answer is satisfactory. If it isn't, please explain the expectation.~

severinbeauvais avatar May 03 '24 16:05 severinbeauvais

@severinbeauvais When a Numbered Benefit company IA filing is started then on the step 1 without entering the user email and phone number they are fetched from the Auth Api or the information in the edit profile page of the account is displayed.

riyazuddinsyed avatar Jun 06 '24 21:06 riyazuddinsyed

Yes, you are correct! Let me look into this a bit.

severinbeauvais avatar Jun 06 '24 21:06 severinbeauvais

There is code to show the user email/phone for Incorporation Applications only. For other filings (eg, Amalgamation, Continuation In), the business contact email/phone is displayed instead (as per my comment above). For Registrations, the user/phone isn't displayed at all.

So what's the requirement here? Should we display user email/phone or business contact email/phone? For which of the above filings?

cc: @yuisotozaki @NaveenHebbale

Currently ...

Filing Show user email/phone? Show business contact email/phone?
Incorporation Application YES no
Registration no no
Amalgamation no YES
Continuation In no YES

severinbeauvais avatar Jun 06 '24 23:06 severinbeauvais

Sample registration:

image.png

severinbeauvais avatar Jun 06 '24 23:06 severinbeauvais

Interesting. Continuation Application should be considered the same as Incorporation Application.

Amalgamation scenario makes sense to keep it as business contact info if it starts from an existing business. If it's a regular horizontal amalgamation from name request (i.e. start with blank business list), I would think we should display nothing as we don't have an entity context.

yuisotozaki avatar Jun 07 '24 16:06 yuisotozaki

@severinbeauvais , Yui's comment looks good to me

NaveenHebbale avatar Jun 07 '24 17:06 NaveenHebbale

This is now implemented and in Dev.

severinbeauvais avatar Jun 07 '24 19:06 severinbeauvais

Test Notes

If you open a continuation in application while logged in as a regular user, you will see the user info in the entity info header (not the business ocntact info).

severinbeauvais avatar Jun 07 '24 19:06 severinbeauvais

Done

NaveenHebbale avatar Jun 07 '24 19:06 NaveenHebbale